Closed (won't fix)
Project:
Ubercart
Version:
6.x-2.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Jun 2010 at 16:41 UTC
Updated:
25 Jan 2016 at 23:01 UTC
Jump to comment: Most recent
Added free shipping for orders over $50, see http://www.ubercart.org/faq/2942#comment-45452 for overview on how it's setup. Works as it should, except when node title has a | in it.
Comments
Comment #1
tr commentedI really don't see how that's possible - neither the CA module nor the "Check order total" condition examines or uses the $node->title value. I suspect that something entirely different is happening. Please provide more information about how you reached your conclusion. Specifically, tell us what you mean when you say it doesn't work - what happens exactly?
Comment #2
rj commentedSee http://www.something-comfortable.com/gallery/12/spanx-sportease-athletic... for a node with a | in the title. If I add 6 items to my shopping cart for a total of $60, it should trigger free S/H, but it doesn't; if you enter cc information and try to proceed to the review order page, it gives the following error message: Invalid option selected. Recalculate shipping quotes to continue. If I remove the | from the node title, free S/H is triggered and it works perfectly.
Free S/H works on every other product in the store. Any insight is appreciated. Thanks.
Comment #3
rj commentedJust as a follow-up, I was able to replicate this issue using a clean install of Drupal and only the Ubercart and Token modules.
Comment #4
tr commentedOK, seems to be a JavaScript problem. uc_quote.js uses "|" internally as a separator for product information, essentially implode()-ing on "|". So the "|" in your product title confuses the AJAX callback uc_quote_request_quote() when it tries to explode() the data.
The proper fix is probably to redesign the format of information passed back to the callback from the JavaScript, since changing the separator character only moves the problem to somewhere else.
Comment #5
longwaveMarked #1322654: Can't use "|" pipe in product titles or sku field as duplicate
Comment #6
longwaveNobody cared enough to fix this in 6 years, it isn't going to be fixed now, and isn't a problem in 7.x-3.x or 8.x-4.x.