The caption/image title that is generated below the inserted image has some ungeneric formatting that should be neutralized imo. For a given title "Test title" you would get:

» Test title

I say, get rid of the "» ", and the underline in the default CSS class (.image-title) in imgupload.css, both can be added by users in theme CSS if wanted.

Anyway, thanks for an awesome module!

Comments

eugenmayer’s picture

eugenmayer commented
Status: Active » Closed (won't fix)

Use the theme function theme_wysiwyg_imageupload_render_meta($img_obj,$arguments) to change it the way you like it.
Or simply overide the CSS.

Neither a bug nor a feature request :)

Anonymous’s picture

Anonymous (not verified) commented

Maybe it's an unfeature request =)

Fine, it's your call of course, but I'd love to hear the reasoning of forcing this unnecessary/arbitrary formatting cruft on a particular node display element. It's not like there's a typographic convention that image captions should be underlined and prefixed with a right double angle mark... It seems more reasonable to have a slim default that can be customized ad nauseum with themeing and CSS rather than the other way around. This is not the module's user interface, it's the rendered output and any predetermined themeing would likely be awkward with approximately all implementations of this module. Would you reconsider if I send a patch?

eugenmayer’s picture

eugenmayer commented

Hi,

iam going for a compromise: I removed the >>, but kept the underline style as i think its fine for picture-titles. I leave all the rest for themers (css .. or even templates ).

eugenmayer’s picture

eugenmayer commented
Status: Closed (won't fix) » Fixed
eugenmayer’s picture

eugenmayer commented
Category: bug » feature
eugenmayer’s picture

eugenmayer commented

Fixed in rc5

eugenmayer’s picture

eugenmayer commented

released in rc5

eugenmayer’s picture

eugenmayer commented
Status: Fixed » Closed (fixed)