Selecting an inserted image in a previously saved node, editing the title in the dialog and then saving the node does not result in an updated display of the title in the image caption. Only after a cache table flush the new title is displayed. Maybe this could be done without administrator intervention?

Comments

eugenmayer’s picture

eugenmayer commented

whait a second:

1.On node A i insert Image a, with a title "title-a".
2 Then on node B i select image a out of the image browser (title should be the filename now, not title-a)
3. Changing the title to title-b and saving

Now in nodeB the title is not correct? or in node A? The title in node A should actually not change at all

eugenmayer’s picture

eugenmayer commented
Status: Active » Postponed (maintainer needs more info)
eugenmayer’s picture

eugenmayer commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

This is a dublicate of http://drupal.org/node/830070 - now iam pretty sure you are talking about changes in node-A. The cache you are talking about is the "filter-cache" and you can configure it on your own or even disable this. It is not planned to share settings ( like titles ) across all this image-uses as you read in the other issue, so this is not needed at all - as not desired to work that way

Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-2.0-rc4 » 6.x-2.0-rc6
Status: Closed (duplicate) » Active

I don't believe it's a dupe. Anyway it's not fixed. More detailed steps to reproduce:

  1. edit new node
  2. choose and upload image
  3. set title "The title" in upload dialog
  4. save node
  5. rendered title is "The title" as it should be
  6. change your mind
  7. edit the node
  8. select the image in the editor
  9. click the "Insert or update image" icon
  10. change the title to "The new title"
  11. save node
  12. rendered title should be "The new title", really is "The title"
  13. call the admin, have him flush the cache
  14. rendered title is now "The new title" as it should be
eugenmayer’s picture

eugenmayer commented
Status: Active » Closed (won't fix)

This is filter cache - not a bug.

Anonymous’s picture

Anonymous (not verified) commented
Title: Cache table flush needed to effectuate change of title » Cache table flush needed to effectuate changes to image properties

This is not only for the title/caption, but also for changes to alignment and image cache preset.

Anonymous’s picture

Anonymous (not verified) commented

Uh, never heard of filter cache. If i click a button saying "Update" (in the dialog of your module), I expect things to update. It doesn't, hence it's a bug. Did you reproduce the behaviour i described or do I have some strange setup?

You mentioned in #3 that the "filter cache" can be configured or even disabled. How? I can't figure out where to do that (but anyway it doesn't sound like a fix).

eugenmayer’s picture

eugenmayer commented
Category: bug » support
Status: Closed (won't fix) » Active

The filter cache should normaly be cleared for updated nodes. I cant reproduce your issue. Do you use some odd content caching?

eugenmayer’s picture

eugenmayer commented
Status: Active » Closed (fixed)

tried it on my installtion and on a clean d.17 with wysiwyG_imageupload. Works in both cases.
Reopen if you have further details or can reproduce it in a clean installation.

Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-2.0-rc6 » 6.x-2.0-rc7
Category: support » bug
Status: Closed (fixed) » Active

Just did a clean install on a different machine just to test. Still the same. Specs:

Drupal 6.17
+ default core modules + OpenID core module
WYSIWYG Image upload 6.x-2.0-rc7
ImageAPI 6.x-1.8
ImageAPI GD2 6.x-1.8
ImageCache 6.x-2.0-beta10
ImageCache UI 6.x-2.0-beta10
jQuery UI 6.x-1.3
+ jQuery UI 1.7.3
jQuery Update 6.x-2.0-alpha1
Wysiwyg 6.x-2.x-dev ( 2010-Apr-08 )
+ CKEditor 3.3.1
+ TinyMCE 3.3.7
JQuery UI Dialog API 6.x-1.8

Added only the Upload image button. Enabled the wiki filter. Added permission. Nothing else installed. No status warnings. Anything you'd like me to try?

Regarding the positioning, this is updated as expected while inside the editor, but not updated in the node view after you resave the node until you flush the cache.

BUT: I have an important clue. The bug is only reproduced if there's no change to anything else in the body (or title...). Theory: Drupal only flushes the cache if it sees the node data is different. And this of course doesn't happen as changes to the image are not saved in the node. (as it's just represented as [[wysiwyg_imageupload:6:]] no matter what changes).

eugenmayer’s picture

eugenmayer commented

Ah i see, that one makes sense!

Thank you for the detailed feedback and your time!

eugenmayer’s picture

eugenmayer commented

actually filter cache is not cleared : http://api.drupal.org/api/function/cache_clear_all/6 ( upper case ).

I have fixed this with http://github.com/EugenMayer/wysiwyg_imageupload/commit/d8b3844aae16229a...

eugenmayer’s picture

eugenmayer commented
Status: Active » Reviewed & tested by the community

Could you please test and review it?

eugenmayer’s picture

eugenmayer commented
Status: Reviewed & tested by the community » Needs review

woops :)

eugenmayer’s picture

eugenmayer commented
Status: Needs review » Fixed

verified that it is working, will be released in rc8

eugenmayer’s picture

eugenmayer commented
Status: Fixed » Closed (fixed)

released in rc8

vthirteen’s picture

vthirteen commented
Version: 6.x-2.0-rc7 » 6.x-2.9
Status: Closed (fixed) » Active

as far as i can see this is still a problem in 2.9 (and in 2.x dev as of today)

drupal 6.22
wysiwyg 6.x-2.3
jquery_ui 6.x-1.4
jQuery Update 6.x-2.0-alpha1
jquery_ui_dialog 6.x-1.10

eugenmayer’s picture

eugenmayer commented
Status: Active » Postponed (maintainer needs more info)

Please try 3.x. I cant reproduce this for me, so you have to debug it yourself and hunt a little :)