The user time zone values are added and substracted from local time values (mktime() and friends), and therefore the resulting datetime values are not right. gmmktime() should be used instead of mktime(), since GMT is what the timezone setting is supposed to be relative to. Here is a patch which fixes part of the problem. It would be nice if someone with understanding of the calendar printout code (or enough time to find out how does it work) would submit a patch against the mktime() issues there. This patch fixes the archive_page time issue.

Probably also relevant for HEAD (patch against 4.4.x CVS)

CommentFileSizeAuthor
#5 modules_archive.module.PATCH865 bytesspoggle
Drupal-archive-time.patch706 bytesgábor hojtsy

Comments

Kjartan’s picture

Kjartan commented

I would like to see a complete patch that handles everything. For that matter I would love to have the archive module improved in general.

Bèr Kessels’s picture

Bèr Kessels commented

Setting this to CVS. We discussed removing this module on the Drupal Sprint. Whenever that happens, we can close this.

paul-at-murphymaphia.com’s picture

paul-at-murphymaphia.com commented

So the solution to the problem is to just scrap the module? This patch doesn't seem to fix the problem in my case. Is there a newer patch?

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Active » Needs work

Changing status.

spoggle’s picture

spoggle commented
StatusFileSize
new modules_archive.module.PATCH865 bytes

I know this is old, but I still see it in 4.7.0 - here is a patch that seems to solve things for me. The original patch was not quite complete and needed one more change to fix it.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Closed (duplicate)

This patch has a better solution for the 4.7.x line. Later versions of Drupal will not include an archive module by default. http://drupal.org/node/73324