In the fckeditor.config.js file, the PHP code protection has been incorrectly commented.

Actually, commenting that line will not prevent the user from typing PHP code in the editor. to do that, even without that line, just go to the source view and submit.

That line instead will instruct FCKeditor to not destroy the PHP code blocks when switching from source to WYSIWYG view. It has nothing to do with security checking.

Code injection controls must be done in the server side, and Drupal does it pretty well. Commenting that line will just bring you troubles when you really want PHP code to be included in the editor source (and this is controlled by the "Input format" box in Drupal pages).

The proposed patch uncomments that line and gives a little bit more info in the comments.

Best regards,
Frederico Caldeira Knabben
----
http://www.fckeditor.net
"Support Open Source Software"

CommentFileSizeAuthor
fckeditor.config.js.patch1.04 KBFredCK
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ontwerpwerk’s picture

Status: Reviewed & tested by the community » Fixed

included in lates cvs

Anonymous’s picture

Status: Fixed » Closed (fixed)