Simply, there's a fatal part error in the template when short tags are enabled.

CommentFileSizeAuthor
opensearch_shortag_parse_error.patch774 bytesneclimdul

Comments

neclimdul’s picture

neclimdul
He/Him
commented
Status: Active » Needs review
Anonymous’s picture

Anonymous (not verified) commented

As reported in http://drupal.org/coding-standards#phptags, short tags should never be used with Drupal; I take that means they should never be enabled with Drupal.

Anonymous’s picture

Anonymous (not verified) commented
Title: Parse error with short tags enabled. » Parse error with short tags enabled
neclimdul’s picture

neclimdul
He/Him
commented

I would say they are not mutually exclusive. And its not a big deal to support them.

neclimdul’s picture

neclimdul
He/Him
commented

This is sort of a critical but trivial bug fix I'd like to see committed. The patch even includes some additional documentation to match the sort of de facto template documentation.

Just a note, this is similar to the approach taken by core's rss.xml handler, views' RSS template, fivestar's AJAX callback and views bonus' xml template. So its pretty common approach to addressing this sort of problem.

Anonymous’s picture

Anonymous (not verified) commented

The code has been changed, and committed.

Thanks for your report.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

I forgot to change status.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.