Just as the title says, this error pops up:
* warning: array_filter(): The first argument should be an array in /Users/edmund/Documents/htdocs/cvs/drupal/modules/comment/comment.module on line 1123.
* warning: Invalid argument supplied for foreach() in /Users/edmund/Documents/htdocs/cvs/drupal/modules/comment/comment.module on line 1123.
Patch checks to see if $edit['comments'] is set and redirects user accordingly.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | check_if_comments_selected_2.patch | 695 bytes | Kjartan |
| #3 | check_if_comments_selected_1.patch | 836 bytes | edmund.kwok |
| #1 | check_if_comments_selected_0.patch | 818 bytes | flk |
| check_if_comments_selected.patch | 771 bytes | edmund.kwok |
Comments
Comment #1
flk commentedthe error seems to occur only when trying to delete a comment....on 'unplish the selected comment' no error occurs.
I have rerolled it against ahead...it does what it says, but on todays head multi-comment delete seems to be broken b0rked.
Comment #2
edmund.kwok commentedYeah, forgot to mention that it only happens with delete comments and not unpublished. Checking if comments were selected is done in comment_admin_overview_validate. But when deleting comments, the comment_multiple_delete_confirm() form is returned instead. Thus comment_admin_overview_validate is not called and hence the error.
Patch was already rolled againts head. The multi-comments delete issue is reported in http://drupal.org/node/82940.
Comment #3
edmund.kwok commentedIssue still applies to HEAD. Rerolling patch, and removed some whitespace.
Comment #4
Kjartan commentedI looked at how node.module did this check and replicated it in comment.module.
Comment #5
edmund.kwok commentedTested on fresh HEAD, much cleaner approach :)
I'd say RTBC since it's a breaks the comment page somewhat but with an easy fix.
Comment #6
dries commentedCommitted to CVS HEAD.
Comment #7
(not verified) commented