It appears that skinr classes are not being printed. I've tested with Hexagon beta2 (both core Hex and my subtheme) and Skinr 2.x-dev. (I don't think it would make a difference with Skinr 1.x, as the classes need to be printed out in both branches, but I'd be glad to test if you think it would be helpful). Skinr works fine when I add the $skinr variable to my subtheme's template files manually as described in http://drupal.org/node/578574#theme

Is there anything else I need to do to enable the plugin? I did not enable it in my .info file as #811958 notes that it autoloads when it detects skinr. If you need any further info / testing please let me know.

CommentFileSizeAuthor
#2 hexagon-829636.patch854 bytesdvessel

Comments

penguininja’s picture

penguininja commented
Title: Skinr compatibility plugin does not printing skinr classes » Skinr compatibility plugin does not print skinr classes

Oops, changing title to fix typo.

Edit: Also, ticket referenced above should be #811958: Basic Skinr support

dvessel’s picture

dvessel commented
Status: Active » Needs review
StatusFileSize
new hexagon-829636.patch854 bytes

It was a typo in the preprocess function. Thanks for spotting!

If it doesn't work, it'll be due to the registry caching and you need to clear the cache. Please mention if you run into this.

penguininja’s picture

penguininja commented

Awesome, thanks for the patch. It's now working great on block skins (i.e. skinr styles enabled via admin/build/block), but the classes still aren't showing up on skins enabled in views, either with block or page displays. This behavior is consistent for both Hex core and my sub-theme.

Re: clearing the cache - I did not have to clear the cache for block skins to work. However, views skins did not work even after clearing the cache.

FYI, I downgraded to the 1.x branch of skinr. (I didn't care for the hovertip cogs/settings in the 2.x branch and there isn't a way to disable that at the moment.) But I can test with the 2.x branch again if necessary.

dvessel’s picture

dvessel commented

Skinr classes will print if Hexagon has a copy of the template. An alternative is to enable the theme wrapper and add some code but I can patch the Skinr compatibility plug-in to take care of some of the work I think. I'll look into this.

dvessel’s picture

dvessel commented

Could you do a quick rundown on how the view is setup with skinr? I haven't explored how skinr interacts with views so I'm not sure how it should be set. Thanks.

dvessel’s picture

dvessel commented

Oh, I think I just figured it out. Nevermind.

dvessel’s picture

dvessel commented

This will allow views to print skinr classes. It wasn't directly related.

#830528: allow views parent template to insert html attributes through preprocess.

penguininja’s picture

penguininja commented

Works great, skinr classes are now getting printed on views. Thanks!

dvessel’s picture

dvessel commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.