The patch,
1. removes the global check of $_GET variables
2. introduces a new menu path filefield/imce/%content_type/%field_name
3. allows directory navigation (as a result of 1 & 2)
4. enables file operations in IMCE 6.x-2.x (IMCE files(uploaded, resized, etc.) can be used in filefield)

CommentFileSizeAuthor
#3 filefield_sources_imce2.patch4.24 KBquicksketch
filefield_sources.imce.patch3.88 KBufku

Comments

quicksketch’s picture

quicksketch
he/him
commented

Thanks ufku! I've often thought about the possibilities of FileField Sources and IMCE together. IMCE's APIs allow for great flexibility in browsing, I'd like to have things like "recently uploaded" and "my files" in the IMCE popup for FileField Sources (see #436182: IMCE lists unusable files (The selected file could not be used because the file does not exist in the database)). This patch leads to much more "official" support for IMCE, my initial approach was mostly experimental. I'll review this when I get a chance.

achton’s picture

achton
Location Denmark
commented

subscribing

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed
StatusFileSize
new filefield_sources_imce2.patch4.24 KB

Thanks again ufku. I've committed this patch with the exception of enabling all IMCE functionality (deleting, uploading, etc.) I'd like to lock this down a little further, since I don't like that IMCE allows uploading of files anywhere in the whole file system (or at least that there's no integration with the FileField upload path settings). We should continue that discussion over at #877452: Enable uploading and deletion through IMCE, but this patch otherwise looks great so I've committed it so that we can go forward with more incremental fixes.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.