I produced the attached screenshot by configuring the dashboard and then dragging a block around within the disabled blocks region. Suddenly, the contextual links appeared! This should never happen :)
Note that the fact that the contextual links appear unstyled in the screenshot is a separate bug (#831082: Contextual links appear unstyled on the dashboard configuration screen when you start off with an empty dashboard). This issue is just about the fact that they shouldn't be appearing within the disabled region at all.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 831088-5.patch | 621 bytes | jody lynn |
| contextual-links-on-disabled-dashboard-blocks.png | 28.3 KB | David_Rothstein |
Comments
Comment #1
David_Rothstein commentedThis might be a duplicate of #639172: Disable contextual links on the dashboard page while within customize mode. That issue is kind of confusing and seems to have evolved in some other direction, so it's hard to tell :)
Comment #2
jody lynnI can't reproduce this one now, re-open if you still can.
Comment #3
jody lynnWait, I just did reproduce it. I had to first drag everything into 'disabled', save it, and then drag the disabled ones around.
Comment #4
jody lynnBasically, contextual.css is not being loaded in this case.
Comment #5
jody lynnThe contextual library needs to be added up front, because if new blocks needing it only appear via AJAX callback, it's too late to add new CSS.
Comment #6
David_Rothstein commentedYour patch is for the wrong issue - it should be posted at #831082: Contextual links appear unstyled on the dashboard configuration screen when you start off with an empty dashboard instead. (And I think your analysis is correct, but I'm not sure about the fix. I thought Drupal's AJAX system is supposed to take care of adding CSS files automatically? It may be that the Dashboard isn't using the standard AJAX system, though.)
The issue here is that the contextual links shouldn't be appearing at all (whether styled or unstyled). Contextual links on a disabled block don't make any sense.
Comment #7
jody lynnAs long as the contextual links are styled they are not invasive so I don't see why it matters if they appear on the disabled blocks. Maybe some people want to configure the blocks before they place them.