when i'm uploading any file in a php 5.3 install with drupal 6.17 and click on attach i get this error
warning: Parameter 2 to advanced_forum_form_alter() expected to be a reference, value given in /www/drupal-6.17/includes/common.inc on line 2839.

the file is uploaded correctly but I don't know why that warning

Comments

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

I've done some researching and haven't been able to figure out why php5.3 has a problem with this and it's documented as being by reference so I'm going to leave it until I can get a definite answer.

Michelle

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Active » Fixed

I went ahead and removed it since I'm not altering the $form_state variable so there shouldn't be any side effects but it is documented as being by reference so it sounds like whatever you're using to upload with is buggy.

Michelle

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Closed (fixed) » Active

This came up in a conversation on IRC and Heine pointed out that my working around core upload's bug means that there's going to be complaints from form_alter calls that do it correctly. So I need to undo this "fix".

Michelle

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Active » Fixed

Committed.

Michelle

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.