it's a little code factorisation because i found some redundant parts.

Comments

gilcot’s picture

StatusFileSize
new1.32 KB

the rewrite impactes sub-componants : here is mysql ones

gilcot’s picture

StatusFileSize
new1.32 KB

the rewrite impactes sub-componants : here is mysqli ones

gilcot’s picture

StatusFileSize
new1.33 KB

the rewrite impactes sub-componants : here is pgsql ones

webchick’s picture

Status: Needs review » Needs work

Hi, please use the "unified diff" format (cvs diff -up > filename.patch) and roll all patches into one where it makes sense. Where it doesn't make sense, they should be separate issues.

If the code you're changing is the same in the CVS version, the patch should be rolled against that version first, then back-ported.

webchick’s picture

Version: 4.7.3 » x.y.z

And actually, if I'm reading the patch correctly it looks like it changes APIs, which means it is definitely not for the stable version. HEAD is frozen now as well, but you can roll the patch and it can be postponed until next time HEAD is open for development again.

gilcot’s picture

StatusFileSize
new10.41 KB

well. I didn't put a look on cvs code and the changes were only tested with 4.7.3 and 4.7.2 But it's compatible with CVS :)
Yes it changes APIs, but nothing change for module developpers.

bdragon’s picture

Version: x.y.z » 6.x-dev
Status: Needs work » Closed (fixed)

I believe that the db stuff got refactored a bit for 6. Drupal 7 will probabaly have a rewrite of the entire subsystem, so I'm just going to go ahead and close this...