See attached patch. It would appear the filefield_view_access changed what arguments it took in one of the recent patches.

CommentFileSizeAuthor
#3 lightbox2.formatter.patch759 bytesDurrok
#1 lightbox2.formatter.patch759 bytesDurrok

Comments

Durrok’s picture

Durrok commented
StatusFileSize
new lightbox2.formatter.patch759 bytes

Might help if I actually attached the patch.

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Needs work

This patch looks like it's been created backwards.

Durrok’s picture

Durrok commented
StatusFileSize
new lightbox2.formatter.patch759 bytes

*facepalm*

Man I am really on it today. Fixed patch below.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Needs review

Sweet, this looks good to me. Shouldn't have any adverse effect on users that are running previous versions of FileField, so this is a backwards-compatible change.

quicksketch’s picture

quicksketch
he/him
commented
Category: bug » task
Status: Needs review » Postponed

I've removed this extra parameter entirely in CVS as part of #833054: argument 2 for filefield_view_access() revisited which will fix LightBox without further changes.

This issue should be able to be closed as soon as FileField 3.6 is released.