Closed (fixed)
Project:
Nagios Monitoring
Version:
7.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Jun 2010 at 11:18 UTC
Updated:
18 Oct 2011 at 23:00 UTC
I do some monitoring via a slow ADSL line. Currently wget errors are treated as CRITICAL errors. I believe they should be unknown as you don't know the state of Drupal. (Some admins may want to alert on UNKNOWN, others may not - at least this way the sysadmin chooses).
The other patch alters the drupal module so that it returns UNKNOWN when patch status is unknown.
I've yet to get to the bottom of why sometimes the module seems to report CRITICAL then OK, then CRITICAL (when I've not patched security issues in the middle). I suspect some timing issue with when patch status information is being collected.
| Comment | File | Size | Author |
|---|---|---|---|
| check_drupal.diff | 1.85 KB | abridgett |
Comments
Comment #1
kbahey commentedLooks like a reasonable change to me.
But I have the following comments:
What does this TODO mean, and does nagios.module has anything to do with it?
Also, the code style is not consistent with Drupal's coding standards, for example:
Comment #2
greg.harveyI don't mind tidying up the code style, but I have no idea what the
TODOmeans!If I clean this up and re-supply, can we get it committed? =)
Comment #3
greg.harveySo the TODO seems to be hinting at perhaps, in the future, making this check per module instead of blanket - at the moment the patch raises a dumb flag to say basically say "this Drupal site has ambiguous update status and should be manually checked", which is subtly different from the blanket "OK" it currently sets.
I've tidied this up and committed it. The Drupal 7 branch will need it too.
Comment #4
greg.harveyNow applied to 7.x-1.x too.