I tested the beta of version 2 with Webform 6.x-3.0-beta5 and got this error:

# user warning: Unknown column 'columns' in 'field list' query: INSERT INTO webform_report (nid, description, wnid, columns, sorton, filters, options) VALUES (13, '', 12, 'a:0:{}', 'a:0:{}', 'a:0:{}', 'a:0:{}') in C:\wamp\www\webform\sites\all\modules\webform_report\webform_report.module on line 242.
# user warning: Unknown column 'columns' in 'field list' query: SELECT wnid, description, columns, sorton, filters, options FROM webform_report WHERE nid = 13 in C:\wamp\www\webform\sites\all\modules\webform_report\webform_report.module on line 194.
# user warning: Unknown column 'columns' in 'field list' query: SELECT wnid, description, columns, sorton, filters, options FROM webform_report WHERE nid = 13 in C:\wamp\www\webform\sites\all\modules\webform_report\webform_report.module on line 194
CommentFileSizeAuthor
#12 832690.patch2.22 KBjimbullington

Comments

jimbullington’s picture

If this was an upgrade from webform reports version 6.x-1.x, did you run update.php on the site?

Marat’s picture

Status: Active » Fixed

I ran update.php and the error disappeared. It works now, thank you very much!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

MBroberg’s picture

Status: Closed (fixed) » Active

Sorry to reopen, but I am getting that error with Webform 6.x-2.9 along with this message:
"There are no submissions for the selected webform. "

There are lots of submissions for my webforms, created both before and after I installed this module.
The webform table shows them, and the 1.x version of Webform Report showed them, but not any report I create now with beta4.

MBroberg’s picture

Oh, and yes I did run update.php, several times, and then uninstalled and reinstalled and ran it again.

MBroberg’s picture

Correction, I feel stupid but somehow I had installed beta1. But now with beta 4 I get this error instead:

warning: Missing argument 1 for webform_report_access() in /home/content/01/5206501/mysite/drupal/sites/all/modules/webform_report/webform_report.module on line 41.

And also:

It appears that no criteria have been specified for this report. Please click on the Criteria tab to add webform data to your report.

I do not have a "criteria tab"

jimbullington’s picture

You are having problems aren't you! I'll see if I can help...

I don't know how you could be getting the 'Missing argument 1' message - there are three references to webform_report_access() in the current beta release:

webform_report.module(116)
webform_report.module(125)
webform_report.module(135)

All are menu access callbacks that are controlled by drupal core.

The missing Report Criteria tab suggests that the module menus have not been rebuilt in your installation.

I would suggest that you clear all of your cache tables and go to 'admin/build/modules' and click 'Save Configuration' to rebuild the menu cache.

MBroberg’s picture

Thank you for your quick response. I went to 'performance" and cleared the cache. I also cleared my browser cache.
I still get the error, and I was getting the error in 6.x-1.x also, but the report was still showing, and I was able to set the criteria, so I had not reported that yet.

One other symptom, related or not?
I have a Node Form Columns module installed. It lets me design how the content type edit form is displayed (turn off buttons or fieldsets, use columns, etc).
When I go to the content type for webform and look at the Manage Form tab, I get this error:

Error - Webform is not set for this report - cannot proceed. Please delete and re-create this report.

The weird thing is that I am not at a report at that point, I am at the content type itself.
admin/content/node-type/webform-report/form

I did disable the Node Form Columns module and cleared caches again, but there was no change to the webform report error.

The full error message actually contains 4 lines:

* warning: Missing argument 1 for webform_report_access() in /home/content/01/5206501/mysite/drupal/sites/all/modules/webform_report/webform_report.module on line 41.
* warning: Missing argument 2 for webform_report_access() in /home/content/01/5206501/mysite/drupal/sites/all/modules/webform_report/webform_report.module on line 41.
* warning: Missing argument 1 for webform_report_access() in /home/content/01/5206501/mysite/drupal/sites/all/modules/webform_report/webform_report.module on line 41.
* warning: Missing argument 2 for webform_report_access() in /home/content/01/5206501/mysite/drupal/sites/all/modules/webform_report/webform_report.module on line 41.

All I can think of is that there is a conflict with another module, but where to start?

MBroberg’s picture

Edit: When I go to the content type for *webform report* and look at the Manage Form tab, I get this error:

MBroberg’s picture

My husband the programmer has been looking at the code and he says that the "access_arguments" column in menu_router table is huge and full of gibberish (huge amount of text, hyphens, etc).
Other modules in that same spot look clean.

He says that he thinks the tab is being created but I, even as user 1, am being denied access because of a permissions conflict.
He says for some reason it is not getting rebuilt even after disable, uninstall, reinstall, etc.

He gave me a direct link to the criteria page.
When I go to node/698/edit/webform_report/criteria
I get access denied.

MBroberg’s picture

update:
first we manually deleted all of the messy data (it was literally huge amounts of garbage) and then disabled and reenabled the modules. It put it all right back it that section of the table.

So my hubby hacked webform_report.module as follows:

in webform_report_menu
for each item where access callback was webform_report_access
stripped away $user argument from "access arguments"
so that webform_report_access will just look at the current user

Now I have permission and can see the criteria page, and no pink error boxes!

Note on UI:
It was not clear before that the "criteria tab" was a subtab under "edit."
The error message just told me to click on the criteria tab.
It might help if the error message, which shows up on the view page, advises to click on edit tab first or provides a link.

In any case that issue is now working - did we mess up something else in doing this?

jimbullington’s picture

StatusFileSize
new2.22 KB

Thank you for the feedback - I'm glad you guys figured it out - tell your husband "Thanks".

I've attached a patch that hopefully incorporates your fix - according to the api it doesn't appear anything will change as far as access goes - the current user will be used. Let me know if it fixes your problem.

MBroberg’s picture

Thank you! Since I have it working I am hesitant to change and try a patch right now, but I will consider it when I get a moment to breathe.

jimbullington’s picture

Status: Active » Needs review

Please review the patch at your convenience.

ub-1’s picture

I had following error while creating a webform on Beta1:

user warning: Unknown column 'columns' in 'field list' query: INSERT INTO webform_report (nid, description, wnid, columns, sorton, filters, options) VALUES (26, 'Test Report', 4, 'a:0:{}', 'a:0:{}', 'a:0:{}', 'a:0:{}') in /home/httpd/vhosts/myweb/sites/all/modules/webform_report/webform_report.module on line 242.
user warning: Unknown column 'columns' in 'field list' query: SELECT wnid, description, columns, sorton, filters, options FROM webform_report WHERE nid = 26 in /home/httpd/vhosts/myweb/sites/all/modules/webform_report/webform_report.module on line 194.
user warning: Unknown column 'columns' in 'field list' query: SELECT wnid, description, columns, sorton, filters, options FROM webform_report WHERE nid = 26 in /home/httpd/vhosts/myweb/sites/all/modules/webform_report/webform_report.module on line 194.

I upgraded to beta4, cleared cache, run update, still had same issue

I added the patch and still had same issue

I checked in my db the table webform_report - the fields columns, sorton, filters and options didnt exist at all

I added them now manually and now everything runs fine at the moment

luthien’s picture

The patch #12 fixed the no Criteria tab problem.

jimbullington’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.