Generally any function that produces HTML should be a theme function, and this function produces HTML. Beyond that principle, I have a practical need to change the output of this function: I don't want to display node titles in slides.

Because this gets called from book_export_traverse, it can't be used directly as a theme function, so I changed the existing function to simply call a new theme function.

CommentFileSizeAuthor
theme.patch1.27 KBsreynen

Comments

hackwater’s picture

Version: 6.x-1.2 » 6.x-1.x-dev
Assigned: Unassigned » hackwater
Status: Active » Needs review

Makes sense, and the patch looks good. Will try to get it in the dev branch and get it tested soon.

hackwater’s picture

Committed your patch; please test the dev release once it updates and let me know if it's behaving properly

hackwater’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.