We should make use of all Drupal caching features in order to improve the performance of Toolbar rendering. The shortcuts are already cached via the menu caching system but the assembly of static links + shortcuts should be cached too. Thus rendering will be required only if shortcuts has changed.

Comments

dankh’s picture

dankh commented

Cache is set :

  • on toolbar rendering : toolbar_footer(), the html output gets cached

Cache is reset per toolbar :

  • on shortcut add
  • on shortcut delete
  • on shortcut reordering
  • on toolbar module disable (reset of cache for all toolbars)
dankh’s picture

dankh commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dankh’s picture

dankh commented
Status: Closed (fixed) » Needs work

The cache code is not ready for production. Needs much more work on it. Many aspects of the toolbar change per user, per link, so only small parts of the toolbar processing code can be cached. Maybe postpone the cache feature for 6.x-3.x after more research of what and how can be cached.