Currently if the two modules are installed, enabled and active on the page, Admin menu is visible over the Toolbar. What action should be taken, if any ?

CommentFileSizeAuthor
#7 833348-3.patch494 bytesdankh
#4 833348-2.patch1.13 KBdankh
#3 833348.patch1.14 KBdankh

Comments

lelizondo’s picture

lelizondo commented

I think the admin_menu adds a body class for when the admin_menu is present. We could use that to give it a margin-top to the toolbar.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Active » Needs review

Add these two rules just after the body.toolbar rule in toolbar.css:

body.toolbar.admin-menu {
  margin-top: 50px !important;
}
.admin-menu div#toolbar-toolbar {
  top:20px;
}

hope the maintainer would accept this as a valid "patch" ;) and merge it in.

Note: Admin_Menu has an option to fix the menu at the top of the screen, whereas Toolbar doesn't, so if you want them to work together, it behoves you to check the "Keep menu at top of page" option on admin/settings/admin_menu

EDIT: Added note ^

dankh’s picture

dankh commented
Status: Needs review » Needs work
Issue tags: +Admin Menu
StatusFileSize
new 833348.patch1.14 KB

Thanks both of you for the insights. As admin_menu is important module we have to make sure that Toolbar integrates well. I have made a patch based on your suggestions but I have a very important issue. When admin_menu is loaded from client side cache (injected in DOM via AJAX) I get 'null' height for admin_menu container.

var adminMenuHeight = $('div#admin-menu').height();

This may be trivial, but I just can't understand why "div#admin-menu" has 'null' height if admin_menu is loaded from cache. The code is simple and works as expected only if I clear the cache (prevent admin_menu to load from cache).

EDIT : I have forgotten one alert for debugging ( alert('scroll') ), sorry for that, please delete it.

dankh’s picture

dankh commented
StatusFileSize
new 833348-2.patch1.13 KB

Second patch to fix the missing units from css values. But the cache problem persists.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

could you explain why you want to do the height adjustment with javascript, instead of just the plain old css?

dankh’s picture

dankh commented

Imagine the user applies some custom css to the admin_menu elements. In admin_menu-6.x-3.0 branch a toolbar style module is included which changes the css of admin_menu. We need to get dynamically the height in order to respect all the changes to height. If we use a static value we won't respect changes to height via css or other modules.

dankh’s picture

dankh commented
StatusFileSize
new 833348-3.patch494 bytes

I'll set fixed values the time we resolve this the right way.

dydave’s picture

dydave commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

Thanks everyone for the efforts and work on this issue! 🙏

More than 15 years of inactivity on this issue for the Drupal 6 version of the module which is not supported anymore.

Therefore, closing as Outdated, for now.

Feel free to let us know if you have any questions or concerns on any aspects of this issue or the project in general, we would surely be glad to help. 😊
Thanks in advance!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.