Title says everything, code is golden, patch is platinum.

CommentFileSizeAuthor
#2 l10n_update-833556-2.patch651 bytesboobaa
l10n_update-uninstall_variables.patch915 bytesboobaa

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

Maybe its best to do the wildcard variable deletion pattern here, since this module is in possibly heavy development and could add/change variables. The db_query('DELETE FROM {variable} .... LIKE 'l10n_update%'"); pattern, I mean, which is used in some contrib modules.

boobaa’s picture

boobaa
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new l10n_update-833556-2.patch651 bytes

Patch updated accordingly.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Looks good, committed, thank you.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.