This is weird, and I'm still investigating it. I'm mostly creating this ticket so that once I've figured out what's going wrong, I can have a ticket number to apply the patch to.

A) I've got a field (field_left) on two node types, and it points to a field (field_right) on one node type.
B) I create a node (#15, say), and point the field_left at existing node 13. When I save, the field_left that I just entered pointing to node 13 is blank... but the field_right on node 13 is successfully pointing back to node 15.
C) If I then *edit* node 15 and set the field_left to point to existing node 13 again, the problem does not recur and the data is correct in both ways.

It seems, at this point, to be a problem with having node 15's field_right calling _backreference_old_values_remove().

Comments

jcfiala’s picture

jcfiala commented

Ah - problem is related to doing a node_load on the right node type before removing the old value. Because of the content cache, the loaded node still contains the old (null) data of the node, and not the updated new data.

For my own reference, here's the change I made:

        else {
          //dpm("Table: $right_table Column: $right_field_column Left Nid: {$node->nid} Right vid: $right_vid, Right nid $right_nid.");
          _backreference_linkback_single_field($right_table, $right_field_column, $node->nid, $right_vid, $right_nid);
          /*db_query('UPDATE {'. $right_table .'} SET '. $right_field_column .'=%d WHERE vid=%d and nid=%d', $node->nid, $vid, $nid);
          if (!db_affected_rows()) {
            db_query('INSERT INTO {'. $right_table .'} (nid, vid, '. $right_field_column. ') VALUES (%d, %d, %d)', $nid, $vid, $node->nid);
          }*/
          // Also, here we need to handle the three-node problem.
          $left_field_info = content_database_info($field_left);
          $left_table = $left_field_info['table'];
          $left_field_column = $left_field_info['columns']['nid']['column'];
          cache_clear_all('content:'. $right_nid .':'. $right_vid, 'cache_content');
          $right_node = node_load($right_nid, NULL, TRUE);

          _backreference_old_values_remove($right_node, $field_right['field_name'], $left_field_column, $left_table);

        }

Of course, I need to create a test before submitting this fix.

techgirlgeek’s picture

techgirlgeek commented

Having the same issue(s).

techgirlgeek’s picture

techgirlgeek commented

Applied your change on my implementation and things miraculously began to work.
Looking forward to the patch. :-)

===========================
Update -- 7/20/2010:

- Noticed that for one of our content types, the back reference only seemed to work from the the content type that had the listing of multiple nodes. However, if we go to the each node that references the "main" content type, the new references don't show up on the "main" content type.

-- Example: Owner has a reference to a content type, say white papers. If you edit the node references for the owner and add 3 white papers, then go to each white paper, it will properly list the owner. However, if we go to each white paper and reference the owner, we go back to the owner and only see one white paper.

jcfiala’s picture

jcfiala commented

I want to do a patch for this, but I'm having a devil of a time reproducing this on a clean environment. Any suggestions/help with setting up a test would be a lot of help.

danrasband’s picture

danrasband commented

I'm having the same problem. Subscribing.

techgirlgeek’s picture

techgirlgeek commented

Anything I can do to help, please let me know. I can reproduce on the project I'm working on. (You know the one.) As of right now we are having to manually add the references on both nodes, since with the fix in place it doesn't seem to update the referenced node any longer. But nothing is disappearing, so definitely an improvement.
-TechGirlGeek

emman31’s picture

emman31 commented

I have the exact same problem:

Type A has 2 fields:
-> field_1:
---> nodereference autocomplete
---> not multiple
---> Referencable type: Type A
-> field_2
---> nodereference autocomplete
---> multiple Unlimited values
---> Referencable type: Type A

Both field are controled by a conditionnal field so that both can't be filled at same time.

I have Content #1 of Type A (both fields empty)

Case 1:
Create Content #2 of type A, filling field_2 with Content #1, save
Content #1 -> field_1 is correctly filled with Content #2
Content #2 -> field_2 is empty.

Case 2:
Create Content #2 of type A, filling field_1 with Content #1, save
both references are made correctly