On my test site, it seems that the first time I log in a user they appear in the "Who's Online" block and stay there. Even though the number of authenticated users goes down when one logs off, their name still appears on the list. The listing is only correct when all users log off and no list is displayed at all.
I will look at the code the first chance I get.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | online_users.diff_1.txt | 1.41 KB | davemicc |
| #2 | online_users.diff_0.txt | 1.41 KB | davemicc |
| #1 | online_users.diff.txt | 1.36 KB | davemicc |
Comments
Comment #1
davemicc commentedI found the problem.
The way the code was doing it was by finding the timestamp of the beginning of the period a user had to have accessed something to count them online. Then, it treated this timestamp like the number of seconds users would be counted online. Essentially, all users that had accessed something since 1970 must've been counted online.
This patch seems to fix the problem.
Comment #2
davemicc commentedThe block still sometimes contradicts itself. If a user logs out of an authenticated session they will still display on the "online users" list for another 15 minutes.
If we change the code to use an inner join against the sessions table when we select the recently active users from the users table I think we can achieve better results. I don't know how much slower this query is.
Comment #3
davemicc commentedAdded table specification to ORDER BY clause in query.
Comment #4
Gurpartap Singh commentedThis seems already fixed in Drupal 5.x HEAD version. Not sure this kind of update will go into Drupal 4.7.x branch.
Comment #5
davemicc commentedYes, it seems to have been fixed in issue #93042. Almost the same as my last patch except their code is supposed to be a little faster.
Comment #6
(not verified) commented