Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This seems to be true for all versions of Drupal shown on api.d.o.
Also the function description is weak; a suggestion is in the patch on the first comment.
Comment | File | Size | Author |
---|---|---|---|
#15 | filter-module2-D6.patch | 2.02 KB | rdrh555 |
#12 | filter-module-D6.patch | 1.97 KB | rdrh555 |
#6 | 834710-filter-xss.patch | 1.99 KB | solotandem |
#5 | 834710-better-doc.patch | 1.98 KB | jhodgdon |
#1 | 834710-filter-xss.patch | 1.01 KB | solotandem |
Comments
Comment #1
solotandem CreditAttribution: solotandem commentedPatch attached; aimed at D7. Similar changes apply to other versions.
Comment #3
solotandem CreditAttribution: solotandem commented#1: 834710-filter-xss.patch queued for re-testing.
Comment #4
jhodgdonGood catch!
However, this proposed documentation does not follow the doc standards.
http://drupal.org/node/1354#functions
- first line verb is wrong tense
- no blank line between @param and @return sections
I also don't like that the first line says it's filtering "for characters". It's doing a lot more than that.
Comment #5
jhodgdonHere's a new patch with rewritten doc.
Comment #6
solotandem CreditAttribution: solotandem commentedSlight wording change on function description.
Comment #7
solotandem CreditAttribution: solotandem commentedMissed the status.
Comment #8
jhodgdonLooks good!
Comment #9
jhodgdonAnd as a note, if this patch is accepted, it should be next ported to Drupal 6.
Comment #10
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #11
jhodgdonComment #12
rdrh555 CreditAttribution: rdrh555 commentedFrom #6
Comment #13
jhodgdonLooks fine, thanks!
Comment #14
jhodgdonOops, spoke to soon: patch needs to be rolled from the Drupal root.
Comment #15
rdrh555 CreditAttribution: rdrh555 commentedEclipse setting.....
Comment #16
jhodgdonThat's it, thanks!
Comment #17
Gábor HojtsyThank you, committed.