Duplicate queries not detected

robertDouglass - September 11, 2006 - 10:10
Project:Devel
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

This applies to both 4.7 and CVS. Duplicate queries are not being detected and we thus lose a major opportunity to detect bad programming practices and wasted resources.

#1

bdragon - November 1, 2006 - 19:35
Status:active» needs review

Found it!
$count needs to get pulled out before $query[0] is manipulated, as the $counts array is indexed by $query[0].

(Patch is against DRUPAL-4-7, fix for CVS is probabaly similar)

AttachmentSize
devel_query_count.patch 810 bytes

#2

robertDouglass - November 17, 2006 - 14:57
Status:needs review» fixed

committed to DRUPAL-5 and DRUPAL4-7. Thanks.

#3

Anonymous - December 1, 2006 - 15:01
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.