This applies to both 4.7 and CVS. Duplicate queries are not being detected and we thus lose a major opportunity to detect bad programming practices and wasted resources.

CommentFileSizeAuthor
#1 devel_query_count.patch810 bytesbdragon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bdragon’s picture

bdragon CreditAttribution: bdragon commented
Status: Active » Needs review
FileSize
devel_query_count.patch810 bytes

Found it!
$count needs to get pulled out before $query[0] is manipulated, as the $counts array is indexed by $query[0].

(Patch is against DRUPAL-4-7, fix for CVS is probabaly similar)

robertDouglass’s picture

robertDouglass CreditAttribution: robertDouglass commented
Status: Needs review » Fixed

committed to DRUPAL-5 and DRUPAL4-7. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)