I was asked to help get eway working with uc_recurring. I don't really like the rebill features of eway and the current recurring implementation in this gateway so I have implemented support for token payments:
http://www.eway.com.au/Developer/eway-api/token-payments.aspx

I have attempted to not disrupt any existing support for the rebill feature (although it looks broken to me anyway?), so you can pick to either using eways recurring rebill feature or the token payments to handle your recurring fees.

Using this features just means that eway can now take full advantage of some of the more advanced features in uc_recurring like allowing admins to edit/change recurring fees, update credit card details.

So far this is has been tested on eways test account and it works.

CommentFileSizeAuthor
#13 uc_eway-835514-13.patch28.87 KBunivate
#3 uc_eway-835514-3.patch28.9 KBunivate
uc_eway_token_payments.patch29.81 KBunivate

Comments

agileware’s picture

agileware commented

Good work mate! :)

agileware’s picture

agileware commented
Issue tags: +uc_recurring
univate’s picture

univate commented
Status: Active » Needs review
StatusFileSize
new uc_eway-835514-3.patch28.9 KB

Some further bug fixes after some testing, you should be able to test with the eway test gateway straight out of the box.

drasgardian’s picture

drasgardian commented

Have been testing this and looks ok. One thing that would be really useful though is for users to be able to update their own cc details rather than only admin.

virtuali1151’s picture

virtuali1151 commented

I have been trying this with the latest dev version and all hunks are failing... any update??? Cheers.

patching file uc_eway.install
Hunk #1 FAILED at 7.
Hunk #2 FAILED at 89.
2 out of 2 hunks FAILED -- saving rejects to file uc_eway.install.rej
patching file uc_eway.module
Hunk #1 FAILED at 43.
Hunk #2 FAILED at 149.
Hunk #3 FAILED at 201.
Hunk #4 FAILED at 240.
Hunk #5 FAILED at 296.
Hunk #6 FAILED at 327.
Hunk #7 FAILED at 347.
Hunk #8 FAILED at 411.
Hunk #9 FAILED at 438.
Hunk #10 FAILED at 461.
10 out of 10 hunks FAILED -- saving rejects to file uc_eway.module.rej
The next patch would create the file uc_eway.pages.inc

The error I get without the any patch.. is as soon as I add a recurring payment on the product features tab I get this error at checkout:

Checkout cannot be completed without any payment methods enabled. Please contact an administrator to resolve the issue.

We have narrowed it down to not being an issue with recurring payments.. it looks to be an issue with the eway mod. As soon as I remove the recurring payment the checkout seems to work ok again.

Any assistance is appreciated.

Also... where can I contrib some funds to this development... you guys have been so helpful I would like to give back.

Cheers.

univate’s picture

univate commented

@drasgardian you should be able to update credit card if you have the permission to "view own recurring fees"

virtuali1151’s picture

virtuali1151 commented

I have confirmed that this issue is related to the eway module. I have tried with other gateway modules, and test gateways and recurring works ok. Any help on this issue is greatly appreciated.

This is the actual error I get at checkout using the eway gateway and having a recurring payment for a product.
"Checkout cannot be completed without any payment methods enabled. Please contact an administrator to resolve the issue."

Is the patch compatible with the latest dev version..?? If so, does anybody know why I am getting these errors:

patching file uc_eway.install
Hunk #1 FAILED at 7.
Hunk #2 FAILED at 89.
2 out of 2 hunks FAILED -- saving rejects to file uc_eway.install.rej
patching file uc_eway.module
Hunk #1 FAILED at 43.
Hunk #2 FAILED at 149.
Hunk #3 FAILED at 201.
Hunk #4 FAILED at 240.
Hunk #5 FAILED at 296.
Hunk #6 FAILED at 327.
Hunk #7 FAILED at 347.
Hunk #8 FAILED at 411.
Hunk #9 FAILED at 438.
Hunk #10 FAILED at 461.
10 out of 10 hunks FAILED -- saving rejects to file uc_eway.module.rej
The next patch would create the file uc_eway.pages.inc

Tks.

virtuali1151’s picture

virtuali1151 commented

Anybody??...:)...

virtuali1151’s picture

virtuali1151 commented

Has anybody been able to confirm they got the eway mod working recurring payments?

virtuali1151’s picture

virtuali1151 commented

bump...

agileware’s picture

agileware commented

@virtuali1151 rather than bumping, poking and getting frustrated about no response. It might be wise to wait until the new year when ppl are back from holidays. That's at least when our team will be again looking at this eway module and recurring payments.

Have a good one ;)

virtuali1151’s picture

virtuali1151 commented

No Worries... Looking forward to it.

Hope you guys are having a good break anyways...:) Even with pests like me..:) hehe..

Cheers mate.

univate’s picture

univate commented
StatusFileSize
new uc_eway-835514-13.patch28.87 KB

The previous patch was done with git and had a/... b/... in the filepath's which is a git thing that wont work with the standard patch command. Here is the same patch from #3 without those.

virtuali1151’s picture

virtuali1151 commented

Ok.. tried this on 6.x-2.x-dev... and got the below error, I stopped it after the first fails...:

patching file uc_eway.install
Hunk #1 FAILED at 7.
Hunk #2 FAILED at 89.
2 out of 2 hunks FAILED -- saving rejects to file uc_eway.install.rej
patching file uc_eway.module
Hunk #1 FAILED at 43.
Hunk #2 FAILED at 149.
Hunk #3 FAILED at 201.
Hunk #4 FAILED at 240.
Hunk #5 FAILED at 296.
Hunk #6 FAILED at 327.
Hunk #7 FAILED at 347.
Hunk #8 FAILED at 412.
Hunk #9 FAILED at 439.
Hunk #10 FAILED at 462.
10 out of 10 hunks FAILED -- saving rejects to file uc_eway.module.rej

Ideas?

univate’s picture

univate commented

Not sure what you are doing, but I just double checked and the patch works fine:

cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -d uc_eway-DRUPAL-6--2 -r DRUPAL-6--2 contributions/modules/uc_eway/
cd uc_eway-DRUPAL-6--2/
wget http://drupal.org/files/issues/uc_eway-835514-13.patch
patch -p0 < uc_eway-835514-13.patch
virtuali1151’s picture

virtuali1151 commented

I am not doing it from CVS... I am just trying to do it from the command line on the server... is this not correct or..?? do I need to do it in CVS..??? Sorry for my ignorance here.. but I am not used to the CVS process...

Tks for your assistance.

univate’s picture

univate commented

it doesn't mater how you get the current 2.x-dev version (cvs or dev snapshot releases), you then need to follow the instructions for apply patches to the modules code - http://drupal.org/patch/apply

The above was just the commands I used, you could also download the dev snapshot, untar and then go to the module directory download the patch and apply (of course the problem with using the dev snapshot to do development is is that they can be delayed up to 12-24hr, so could be missing commits - less likely with this modules but other more active modules it can be a problem).

virtuali1151’s picture

virtuali1151 commented

Ok... I had to delete the mod and redownload it.. and then the patches worked fine (Thank you). and it seems to have fixed that error!! AWESOME!! Thank you!!

I seem to be having one other drama with the nusoap path...

When I add the relative path to the nusoap directory it still says "NuSOAP library not found". Is this just an error or should it show it as active or something? Even if I try will an absolute path it still doenst want to find it? Not sure what I might be missin here.

Again, sorry to be a pain.. just really need this to work...:) Any assistance is appreciated.

Tks.

virtuali1151’s picture

virtuali1151 commented

Got it to work.. had to use an absolute path. tks.

virtuali1151’s picture

virtuali1151 commented

Has anybody been able to update credit card details as per #6..??

Cheers.

virtuali1151’s picture

virtuali1151 commented
Status: Needs review » Active
univate’s picture

univate commented
Status: Active » Needs review

There is a patch here, so the status should be set to needs review.

agileware’s picture

agileware commented
Status: Needs review » Fixed

Thanks for this, it's awesome!

I have committed the patch in #3 with a few changes:
* A few coding standards and unnecessary changes issues.
* Changed a few comments that referred to the securepay module.
* Removed the parts that were also in the patch at #785990-3: Please test recurring patch as that patch was already committed.
* Removed the hook_requirements() parts out into their own issue (they have been committed separately at #1140872: Use hook_requirements to force requirements of curl and simplexml)
* Changed the hard coded 'au' country codes to use the country code of the billing address.
* Made the test custom id a constant.
* Added testing functionality for the customer reference, whcih for testing should be "Test 123"

Please can people in this issue also see #1141916: Remove eway recurring fucntionality and make eway token payments the only recurring payment option and add your two cents.

http://drupalcode.org/project/uc_eway.git/commit/b5b80c7

Status: Fixed » Closed (fixed)
Issue tags: -uc_recurring

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +uc_recurring

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.