1. User haven't comment permission but can see any comments.
2. On full node view drupal show "Create" or "Register" links.
3. But after "Registration" we get "page not found.

Attached patch fix it.

CommentFileSizeAuthor
#10 comment.module-from_cvs-d6.patch2.06 KBvadym.kononenko
#7 comment.module-from_cvs.patch2.06 KBvadym.kononenko
#3 comment.module-from_root.patch1.8 KBvadym.kononenko
comment.module.patch1.77 KBvadym.kononenko

Comments

Status: Needs review » Needs work

The last submitted patch, comment.module.patch, failed testing.

Druid’s picture

Druid commented

I'm seeing a lot of reports of this kind of thing, where evidently a URL string is being fed through cleanup/sanitizer twice. "#" becomes "%23" on the first pass, and on the second, the "%" gets sanitized to %25, leaving you with "%2523" instead of just "%23". Anyway, that might give someone a clue where to look.

vadym.kononenko’s picture

vadym.kononenko commented
Status: Needs work » Needs review
StatusFileSize
new comment.module-from_root.patch1.8 KB

Recreate patch from drupal root.

Status: Needs review » Needs work

The last submitted patch, comment.module-from_root.patch, failed testing.

vadym.kononenko’s picture

vadym.kononenko commented

Should I recreate it again or you apply it as is? I've tested it. All works correct. And patch is applying correctly too.

dddave’s picture

dddave commented
Status: Needs work » Needs review

The test function for D6 test is broken/not working so this needs to be reviewed the old fashioned way.

vadym.kononenko’s picture

vadym.kononenko commented
StatusFileSize
new comment.module-from_cvs.patch2.06 KB

Attempt number three :)
I've recreated patch from drupal.org CVS as it is described on the page http://drupal.org/node/550576

Status: Needs review » Needs work

The last submitted patch, comment.module-from_cvs.patch, failed testing.

dddave’s picture

dddave commented
Version: 6.17 » 6.19
Priority: Minor » Normal

I guess you assured that this problem still exists in 6.19 and therefore I updated the version. Also upped the priority a notch.

Please take note that the testing fails because this is a patch for D6. Simply put a -D6 before .patch to prevent the testbot choking on your patch. See: http://drupal.org/node/332678

vadym.kononenko’s picture

vadym.kononenko commented
Status: Needs work » Needs review
StatusFileSize
new comment.module-from_cvs-d6.patch2.06 KB

It is just a game... :)
Attempt number four.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 6.19 » 7.x-dev
Priority: Normal » Major 
+++ modules/comment/comment.module	17 Sep 2010 14:09:06 -0000
@@ -1798,19 +1798,19 @@ function theme_comment_post_forbidden($n
-        $destination = 'destination='. rawurlencode("node/$node->nid#comment-form");
+        $destination = 'destination='. rawurlencode("node/$node->nid");

looks like this patch is very simple and clear for me
Not see any ugly code here
But we need to fix it in Drupal 7 before aplying at Drupal 6 (If bug present there)

Powered by Dreditor.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Please reroll this patch for D7 first also needs a test coverage

naxoc’s picture

naxoc commented

I cannot recreate this in D7. Anyone who can?

catch’s picture

catch
he/him
Primary language English
commented
Version: 7.x-dev » 6.x-dev
Issue tags: -Needs tests

Looks like this code changed a fair bit in D7, I'm moving back to D6 since no-one can reproduce it there, I didn't try myself.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.