I put this in infrastructure rather than project module, because I can't envision a way to add a very specific rule about Drupal's development procedures into a module intended for general consumption.
In watching the issue queue, I see several times a day people going into issues and issuing a reply to set feature requests to the 'cvs' version manually, the author patiently explaining each time, "Feature requests go into CVS." Boy does that seem like a collossal waste of time to me; time which could better be spent reviewing patches and fixing bugs. :P
I don't know that we have an existing custom module for Drupal.org-specific enhancements, but either way, what about adding a custom validate function in hook_form_alter to basically do:
if (project == 3060 && type == 'feature request' && version != 'cvs') {
form_set_error(t('Feature requests must go against the CVS version.'));
}
I'm sure I could whip the exact code up later if people think it's a good idea.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | project_drupal_org_0.module | 1.4 KB | webchick |
| #4 | project_drupal_org.module | 1.38 KB | webchick |
Comments
Comment #1
dww+1. i love it.
we don't yet have a project_issue_drupal_org.module, but we could sure use one. ;) that'd be much easier than trying to make this sort of behavior generic enough to be potentially useful (or at least, not harmful) to other sites. i'd still be in favor of putting project_issue_drupal_org.module (or whatever reasonable name we can come up with) directly in the project_issue directory (or a subdir) instead of a whole new project, since i think other users of project_issue might want to see the sorts of customizations that are going on at drupal.org. i often see issues where people are asserting (incorrectly) that "the version of project running on drupal.org *must* be different, since XXX", which isn't true.
of course, we'd probably also want a 1-time script that finds all existing issues that aren't right and resets the version with basically the same text...
webchick if you want to spear-head the effort, i'd be happy to review and commit this stuff to project_issue, maintain it, and make sure killes installs it on d.o. i just need to focus on the release system for now, so i'd rather not work out all the actual code.
thanks!
-derek
p.s. from the stand-point of moving the project-related code to being more clean and modular, i've been splitting functionality into separate modules (project vs. project_issue and now project_release). eventually, some of the hard-coded node types could be customizable (so you could apply project_issues to any kind of node, not just a project_project node). however, for the sake of over-all simplicity for this particular issue, maybe we just want a global project_drupal_org.module for all d.o-specific customizations across the whole family of project-related modules. technically, it's a little weird this way, but it's sort of a hack to begin with. ;) i suppose we could always start by putting everything in project_drupal_org.module and eventually re-organize the code later if it turns out to be a problem.
Comment #2
gregglesDon't we automatically move issues from fixed to closed after a certain amount of time? That seems like a site specific kind of thing to me. Where is that handled?
Wherever this stuff ends up they should probably be together.
Comment #3
dwwDon't we automatically move issues from fixed to closed after a certain amount of time? That seems like a site specific kind of thing to me. Where is that handled?
yes. it's at the end of
project_issue_cron()(hook_cron) in project_issue.module, starting around line 114. i don't think it's all that site-specific, but we should probably add a setting to control the time period (which could also be used to disable the behavior if you don't want it, e.g. if you enter a period of 0, that means not to do it or something)...but, that's off topic for this discussion. ;) when/if this drupal.org-specific project customizations module exists, we can generate new issues for moving code into it for behavior that's currently in project.module and friends that a) can't be easily customizable and b) is entirely specific to our needs. any functionality that we want to debate moving should be in its own issue/patch, since we'll want to handle them all separately.
let's leave this issue for discussing the task at hand: a new feature to prevent feature requests against core that aren't for the "cvs" version, and a 1-time script to move all mis-classified issues to the right version...
thanks,
-derek
Comment #4
webchickOk, here is a module which I "think" should do this. I can't actually test this because I have no idea how to get a "version" field to show on my issue. I'll try and catch dww online at some point for support on this. In the meantime, people can check it out and see what they think.
Comment #5
webchicknote: the "one time" script isn't implemented because I need to know how stuff is getting stored in order to actually do it. I'm also not sure that should be part of the module, but rather some sort of custom SQL command that's run once against drupal.org.
Comment #6
webchickMy head is clearly up my bee-hind today. ;)
Comment #7
webchickAh, cool. Figured it out. And for the record, I was able to test this locally with different project/release ID values and it does seem to work.
Here is a query that should change all the existing values:
(goes without saying, but obviously, please test it first before wantonly using it on Drupal.org, but again it "works for me" on my humble test environment of only a few nodes. :))
Comment #8
dwwre #7: personally, i'd rather we did this like project_issue_cron() does for closing issues that have been fixed for N days, instead of a silent SQL query. it'd be nice to actually save a new comment that explicity moves the version with the appropriate text, so that the owners/submitters of these issues see the issue was bumped, and why...
others might disagree, however, so i won't spend any more time on it than this. ;)
thanks for all the effort on this, webchick!
-derek
Comment #9
webchickOh, I see. Sure, I can write a little one-time script to do that.
Comment #10
michelleThere's no "cvs" version anymore but it would be nice if feature requests automatically got bumped to the next version of Drupal when it opens up.
Michelle
Comment #11
avpadernoIs there any development with this feature, or should the report bee marked as ? If I remember well, there is another request to automatically pass the unresolved feature requests to the latest Drupal version.
Comment #12
tvn commentedClosing old issues.