Markup is in #value, should be in #prefix/#suffix

So, at the moment, when these modules inject their links (using hook_nodeapi), they add an element to the $node object that has a #value of "<span class='print-link'></span>". To populate this HTML div, they then do a preg_replace on the #value, replacing the closing '</span>' with '[the new link]</span>'.

This is, to put it bluntly, wrong.

The markup should be placed in #prefix (opener) and #suffix (closer) attributes. With this in place, adding subsequent links becomes a matter of simple concatenation rather than the more intensive preg_replace function. (By happy chance, it also removes the need for an 'if' statement, as it doesn't matter if you concatenate an empty string onto it.) It's also much easier for other developers to step in and theme the block, and further, the #prefix/#suffix doesn't render when the #value is empty. Which is nice.

To be frank I'm not 100% sure this shouldn't be done elsewhere - say, by populating the links during the 'load' step, and passing the pre-built links to a theme function in the 'view' step - but that's beyond my immediate concern at the moment.

Find attached some .diffs (generated by my text editor, I have no knowledge of patch file construction) to apply these changes to print.module, print_mail.module and print_pdf.module, which appear to be the only places the 'print_links' element is referenced - haven't had time to chase any other references down.