Hello!

I have updated the module for 5.0 and also added an align functionality via css. It tries to keep backward compatibility in tags:
[in_line:2:right]

I renamed the module to in_line because the new module api in 5.0 did not accept names begining with 'inline'. If that is fixed it can be easily replaced back.

regads,

pentike

CommentFileSizeAuthor
#3 inline.patch.txt4.95 KBpentike
in_line.patch.tar.gz4.12 KBpentike

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

Please don't compress patches here.

Patch tries too many things at once. Could you provide a patch for 5.0 only?

pentike’s picture

pentike commented

Sorry, I sent the patch compressed, because it includes the in_line.info and inline.css files also and there is only one upload field.

The new feature modifies only 7 lines the others are required for work with 5.0:

135 drupal_add_css("modules/in_line/inline.css");

195 $html .= 'Only local images are allowed.width.'px; height:'.$file->height.'px;" src="'. file_create_url($file->filepath). '" class="'. (empty($file->align) ? '' : ''.$file->align).'" alt="'. $title .'" title="'. $title.'" />';

259 if (preg_match_all("/\[(in_line|file|attachment):([^=:\\]]+)=?([^:\\]]*)?:?(left|right|centre)?\]/i", $node->content["$field"]["#value"], $match)) {

265 $align = $match[4][$key];

269 if (!empty( $align )) {
270 $file->align = $align;
271 }

pentike’s picture

pentike commented
Status: Needs work » Needs review
StatusFileSize
new inline.patch.txt4.95 KB

According to http://drupal.org/node/83565 and http://drupal.org/node/83408 the module naming problem solved, so here is a new patch for inline.module cvs to update to 5.0.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Marking as duplicate of http://drupal.org/node/105137.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Closed (duplicate)