Closed (fixed)
Project:
A Sync Template
Version:
6.x-1.9
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Jun 2010 at 03:26 UTC
Updated:
1 Sep 2010 at 22:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
durentu commentedthese //id lines appears at the top of the following files:
block.tpl.php
box.tpl.php
comment.tpl.php
node.tpl.php
page.tpl.php
template.php
the //id lines are rendered in the final page in various places, which wasn't the original intent.
The other files have the id lines, but are correctly commented
QuickFix:
Delete the line from the above files or comment them out by hand.
Comment #2
cafuego commentedNo need to remove them; they're the CVS version tags which can be useful. They just need to be embedded in PHP open and close tags, so they're evaluated and optimised out of the final output.
Patch attached.
Comment #3
pimentoski commentedi cannot apply the patch, can you send the new php files so i can replace it in the server?
Comment #4
cafuego commentedFull fixed theme tarball attached.
Comment #5
kpm commentedI just grabbed the ASYNC theme to give it a try and have the same issue with the version tags showing up.... and I'm a bit confused as to why this is... Is this a bug that the patch fixes? Or is this the usual behaviour for this theme. I've been maintaining sites with CVS (I am not a developer or coder, but grab modules and themes using cvs rather than downloading them, uploading them, extracting them, repeat for updating, etc, etc) for a while now and haven't experienced this, but I've also never applied patches, just ran the cvs update commands... Which brings me again to the question... is there a version, other than the ASYNC version -6--1-11 that I can use that this condition has been corrected on... that is, if it is a bug to begin with... Hope that makes some sense... Thanks
Comment #6
cafuego commentedIt's a bug. The tarball that is attached above contains a copy of the theme with the fix applied. The patch above that fixes the problem on the original project tarball download.
Comment #7
cafuego commentedComment #8
finex commentedThanks, I've just fixed the files :-)
Comment #9
finex commentedPlease download the new .12 release :-)