block.tpl.php and page.tpl.php are at least effected, can be seen http://drupalcode.org/viewvc/drupal/contributions/themes/async/page.tpl...., the //id is at top of the document.

I believe the appropriate format can be seen http://drupal.org/coding-standards, for php tags (putting the id inside php)

CommentFileSizeAuthor
#4 async-836286.tar_.gz459.42 KBcafuego
#2 836286.patch3.72 KBcafuego

Comments

durentu’s picture

these //id lines appears at the top of the following files:

block.tpl.php
box.tpl.php
comment.tpl.php
node.tpl.php
page.tpl.php
template.php

the //id lines are rendered in the final page in various places, which wasn't the original intent.

The other files have the id lines, but are correctly commented

QuickFix:

Delete the line from the above files or comment them out by hand.

cafuego’s picture

StatusFileSize
new3.72 KB

No need to remove them; they're the CVS version tags which can be useful. They just need to be embedded in PHP open and close tags, so they're evaluated and optimised out of the final output.

Patch attached.

pimentoski’s picture

i cannot apply the patch, can you send the new php files so i can replace it in the server?

cafuego’s picture

StatusFileSize
new459.42 KB

Full fixed theme tarball attached.

kpm’s picture

I just grabbed the ASYNC theme to give it a try and have the same issue with the version tags showing up.... and I'm a bit confused as to why this is... Is this a bug that the patch fixes? Or is this the usual behaviour for this theme. I've been maintaining sites with CVS (I am not a developer or coder, but grab modules and themes using cvs rather than downloading them, uploading them, extracting them, repeat for updating, etc, etc) for a while now and haven't experienced this, but I've also never applied patches, just ran the cvs update commands... Which brings me again to the question... is there a version, other than the ASYNC version -6--1-11 that I can use that this condition has been corrected on... that is, if it is a bug to begin with... Hope that makes some sense... Thanks

cafuego’s picture

It's a bug. The tarball that is attached above contains a copy of the theme with the fix applied. The patch above that fixes the problem on the original project tarball download.

cafuego’s picture

Status: Active » Needs review
finex’s picture

Status: Needs review » Fixed

Thanks, I've just fixed the files :-)

finex’s picture

Please download the new .12 release :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.