Closed (fixed)
Project:
Weather
Version:
6.x-5.x-dev
Component:
Code
Priority:
Critical
Category:
Feature request
Assigned:
Reporter:
Created:
24 Jun 2010 at 12:26 UTC
Updated:
17 Jul 2010 at 18:50 UTC
Jump to comment: Most recent file
Hi.
The "Download location for METAR data is not accessible." message is visible to all. It would be great to only show that message to admins.
Thanks.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | weather-836582.patch | 665 bytes | aaronelborg |
Comments
Comment #1
dokuf commentedSubscribe!
I now get the error since a few days and everybody can see it...
Comment #2
johnnocComment #3
jboeger commentedSame here!! very frustrating.
http://www.americascupalameda.com
Comment #4
MrNetworker commentedYes Im also noticing lots of messages over the last few weeks.
Is it me, it seems the caching of the METAR data is not working?
I can refresh the page after 2 minutes and its redownloaded the data.
Is NOAA throttling the data?
Cheers
Comment #5
MrNetworker commentedUpdate: Just noticed one thing with my sites.
Make sure the date and time is set correctly. Administer » Site configuration » Date and Time
I noticed this when I was looking through the logs.
Mine was on +13 hours when it should have been +12 hours. It look like the updates are working better now since it’s not always 1 hour ahead and updating every page refresh.
Comment #6
sopia commentedI'm having this same problem. "Download location for METAR data is not accessible" message on many pages. Many more than usual in the last couple of weeks. Had to turn off the block temporarily (hopefully!).
Would be good to be able to switch off the message to all non-admins so we don't have to worry about this message showing up on old pages as we look into the problem.
Comment #7
toddy commentedHi,
it's no problem to remove the error message. What would you like instead? Would an entry in the watchdog tables be enough? That way, any administrator could see the problem, while end users do not get that message.
Regards,
Tobias
Comment #8
joetheyeti commentedI kept getting the same METAR error message after the module working well for weeks. I get the error fairly frequently. I couldn't get the error message to go away even if I told Drupal to write all errors to the log and not the screen. Here's my solution:
I hacked the module code and get the error to stop showing up on my web site. I HIGHLY recommend making a backup of the original code before you do this, so you can revert if you need to.
To remove the METAR error message:
1) Open the file weather.module (from the sites>all>modules>weather folder) in a simple text editor (WordPad works well, DON'T use MS Word)
2) Scroll to the bottom
3) Delete the following code:
// check on errors
if ($metar_raw === FALSE) {
drupal_set_message(t('Download location for METAR data is not accessible.'), 'error');
}
4) Save the document
5) Upload the document to your Drupal site
I don't know if this hack has repercussions, so you it at your own risk. It worked great on my site. If the METAR data isn't available, the weather module simply displays a question mark graphic and a nice, discreet "No data" message underneath it. But you DON'T get that ugly-ass error message in the red box at the top of the page.
Comment #9
izmeez commentedI was redirected to here from the discussion at http://drupal.org/node/838280
[Edit] I have posted more updates to the other issue queue and editing some of this post. [/edit]
I don't know which is the best thread to discuss this in.In my case, yes the METAR data not accessible error is displayed. But the bigger problem is the module is not working now so I presume the error message is correct.I'm not looking for a feature to hide the error message except for admins but to find a way for the METAR data to be accessible again.Is this a bug or is it because I am using private file downloads?I have gone back to 6.x-5.11 and it works. I have also posted a brief note in the other thread.Sorry, I did not want to hijack this thread unless they are related issues.
Thanks.
Comment #10
aaronelborg commentedIf the user has the permission of 'administer custom weather block', this message should only be shown to them.
Comment #11
toddy commentedThis is now fixed in CVS, thanks a lot for the patch. It'll be released shortly.
Regards,
Tobias