Do not show node queue tab when nodequeue_node_access() returns false
mansion - September 12, 2006 - 10:26
| Project: | Nodequeue |
| Version: | 4.7.x-1.1 |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Jump to:
Description
Hi,
I don't see the need to have the node queue tab cluter the interface if the node type cannot be added to a queue. This can be done with a simple check in nodequeue_menu(), line 66 of // $Id: nodequeue.module,v 1.36 2006/08/03 16:28:59 merlinofchaos Exp $
<?php
if (nodequeue_node_access($node->type)) {
$items[] = array(
'path' => 'node/' . $arg1 . '/nodequeue',
'title' => t('nodequeue'),
'access' => $access,
'callback' => 'nodequeue_page',
'callback arguments' => array($arg1),
'type' => MENU_LOCAL_TASK,
'weight' => 5
);
}
?>Do you think this makes sense ?
#1
This code was added but commented out in the current 4.7 release.
Any good reason why it's commented out? If not, please uncomment it, as it makes sense.
#2
This seems to be back in 1.2
#3
The nodequeue 1.x line is no longer available.