Hi Brian,
Now it is working I have another question.
Only the global tokens are right now used to replace possibilities in the page_title on custom pages. Could also the other tokens, like taxonomy_tokens, cck_tokens be used as replacement please?
(I asked the same question also in the nodewords issuequeue :)
greetings, Martijn

CommentFileSizeAuthor
#11 nodewords-dev.zip7.55 KBBrian294
#7 nodewords-beta9-v2.zip7.06 KBBrian294
#5 nodewords_beta9.zip6.7 KBBrian294
#3 nodewords-beta9-fix.zip6.64 KBBrian294

Comments

Brian294’s picture

Brian294 commented

Hi Martijn,
Thanks for submitting an issue in the nodewords queue. I have submitted a patch for nodewords.module that should fix the issue. It's against the most recent -dev version. FYI - you need to use the -dev version of nodeword_pagetitle if you want to use the -dev version of nodewords. There is an API change in nodewords.
http://drupal.org/node/837108#comment-3140234

Brian294’s picture

Brian294 commented
Assigned: Unassigned » Brian294
Status: Active » Needs review
Brian294’s picture

Brian294 commented
StatusFileSize
new nodewords-beta9-fix.zip6.64 KB

For anyone using nodewords-beta9, here is the nodewords.module file you'll want to copy to your nodewords directory.

summit’s picture

summit commented

Hi Brian,
Will test this this week. Great! I am on Nodewords Beta9. Nodewords further on the line have still issues regarding showing the metatags.

greetings,
Martijn

Brian294’s picture

Brian294 commented
StatusFileSize
new nodewords_beta9.zip6.7 KB

Thanks Martijn! Do me a favor, use this file instead. kiam brought up a good point about determining if an arg id belongs to a node, taxonomy, or user. This will ensure that the node/user/taxonomy tokens are not loaded if we our outside of their respective context.

summit’s picture

summit commented

Hi Brian,
I tested the patch. But I do not see the other tokens arising on the Custom pages meta tags page.
I thought they would arise, just as on the regular Page title page would.
May be related to: http://drupal.org/node/781440#comment-3150522

EDIT: I build this TokenArgument module, see: http://drupal.org/node/273893#comment-3151404 now the arguments are working! Only other tokens still not shown on Custom pages meta tags

greetings,
Martijn

Brian294’s picture

Brian294 commented
StatusFileSize
new nodewords-beta9-v2.zip7.06 KB

yeah, I think you're right. I threw this together really quick for you to try. Let me know if that resolves the issue in beta9.

Peace,
Brian

summit’s picture

summit commented

Hi Brian,
Yes the nodewords.module in #7 is giving the other tokens also for beta9!
Would be great if you would file a patch for kiam to get this in.
Thanks a lot for the great support.

greetings,
Martijn

Brian294’s picture

Brian294 commented

Martijn, thank YOU for being a great user! I'll whip up the dev patch tonight.

summit’s picture

summit commented

Hi Brian,

I have arg() now working great. And all tokens are showing in nodewords custom pages.
But when I try to use, say a cck field token, It is not showing.
Is what tokens are shown, related to the url? I have a selfmade url on which I would love to have termnames in the title, metatags description, and metatags keyword.
Would this be doable, my url is for instance. http://www.campings-europa.com/land/Nederland

Greetings,
Martijn

Brian294’s picture

Brian294 commented
StatusFileSize
new nodewords-dev.zip7.55 KB

Hi Martijn,
I submitted a patch to add additional tokens to the -dev version:
http://drupal.org/node/781440#comment-3163690

This fix does pretty much everything that the beta9 patch does, but takes into consideration a few more things. I tested CCK with this patch and it worked, although I did not make any changes to nodewords.module to address CCK.

I have attached the full nodewords.module file that can be applied overtop the current -dev version.

Peace,
Brian

PI_Ron’s picture

PI_Ron commented

Thanks for this patch guys, works great and much appreciated.

PI_Ron’s picture

PI_Ron commented

Hi Again,

Would there be a way to use tokens from http://drupal.org/project/term_fields within a custom pages meta tags?

Ive installed the dev version of this module, which I thought generated tokens based on the custom term fields, but they do not show up in the custom pages edit screen.

I thought it would be great to be able to setup custom term fields for 'Page Title', 'Description' etc. then use their tokens within a custom page, that way when setting up a term you could also set the meta tags directly from the term edit screen, and use one custom page meta tags setup for a vocab, instead of heaps.

What do you think?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

The upstream issue with nodewords (#781440: Missing tokens) has been fixed. Do we need to keep this issue open at all?

summit’s picture

summit commented

Hi Tim, I think you have to file a new issue to get attention on it.
greetings, Martijn

Brian294’s picture

Brian294 commented
Status: Needs review » Closed (fixed)

Closed per David Reid's comment in #14.