It would be handy to obtain the Session ID from the watchdog messages, like the Drupal 6 and 7 branches do. The attached screenshot is the details view of what is now presented in the report.

CommentFileSizeAuthor
#6 mollom-DRUPAL-5.watchdog.6.patch1.77 KBsun
#4 mollomincorrectcaptcha.patch1.69 KBrobloach
#2 837684.patch820 bytesrobloach
mollomwatchdog.patch2.91 KBrobloach
Screenshot.png47.07 KBrobloach

Comments

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks Rob!

robloach’s picture

robloach
he/him
commented
Status: Fixed » Needs review
StatusFileSize
new 837684.patch820 bytes

Whoops, forgot some debugging code......... Also, THANKS! :-)

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to DRUPAL-5. Thanks.

robloach’s picture

robloach
he/him
commented
Status: Fixed » Needs review
StatusFileSize
new mollomincorrectcaptcha.patch1.69 KB

This will make the reports appear for the User Registration form.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work 
+++ mollom.module	28 Jun 2010 15:11:52 -0000
@@ -723,7 +723,6 @@
       watchdog('mollom', t('Ham: %message<br />Data: <pre>@data</pre>Result: <pre>@result</pre>', array('%message' => $data['post_body'], '@data' => print_r($data, TRUE), '@result' => print_r($result, TRUE))));

D6+

+++ mollom.module	7 Jul 2010 16:08:55 -0000
@@ -771,13 +772,13 @@
-          watchdog('mollom', 'Incorrect CAPTCHA');
+          watchdog('mollom', t('Incorrect CAPTCHA. This is the associated data: <pre>@data</pre>', array('@data' => print_r($data, TRUE))));
...
-          watchdog('mollom', 'Correct CAPTCHA');
+          watchdog('mollom', t('Correct CAPTCHA. This is the associated data: <pre>@data</pre>', array('@data' => print_r($data, TRUE))));

Can we use the same, shorter notion in D5?

watchdog('mollom', t('Incorrect CAPTCHA.<br />Data: <pre>@data</pre>', array('@data' => print_r($data, TRUE))));

Powered by Dreditor.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Category: bug » task
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new mollom-DRUPAL-5.watchdog.6.patch1.77 KB
robloach’s picture

robloach
he/him
commented

Ah! Thanks a lot for updating the patch. RTBC++ed.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to DRUPAL-5.

It has been 9 months since we made a Drupal 5 release for Mollom, and if I remember correctly we made a couple of small changes since. I'm thinking maybe we should make a new Drupal 5 release? Probably time to go through the commit log and to compile a list of all the changes to the DRUPAL-5 version of Mollom, to do some manual testing, etc.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.