Allow different default role by content type

Hi Sarenc,

I've rewrote the module to accomplish that (Sorry SUN, it is quite simple patch that you can include in main branch)

so Now You can choose default role to be different by OG content type

@destination_node: Can you attach a patch with the required changes for this issue only?

Here is the above as a patch against the latest in CVS.

There is a bug in this patch. Node is not loaded for user update case in the hook_og() implementation:

function og_user_roles_og($op, $nid, $uid, $args = array()) {
  switch ($op) {
    case 'user insert':
      ...
    case 'user update':
      $default_admin_role = variable_get('og_user_roles_default_admin_role_'.$node->type, 0);
      ...

should be like this:

function og_user_roles_og($op, $nid, $uid, $args = array()) {
  switch ($op) {
    case 'user insert':
      ...
    case 'user update':
      $node = node_load($nid);
      $default_admin_role = variable_get('og_user_roles_default_admin_role_'.$node->type, 0);
      ...

subscribing

Haven't tested it quite yet, but here's a patch with the above in mind. the preview patch also had an unrelated slight bug fix, so did not include that.

However, settings this to needs review as the upgrade patch for existing sites isn't handled.

subscribe

Updated to remove calls during node_load during hook_nodeapi 'insert' (as user [author] is added during insert of group)

Add setting the cache during 'insert' to prime it for user insert

Missed a spot needing to be changed