Simplemenu 1.5 to 1.8 breaks javascript sitewide (if files is not created, old behavior does not take over automatically.)

I'm using FCKeditor, and obviously I have collapsible fieldsets...

If you cleared the site cache, then it would have made the new JS that gets created to include the simplemenu variable declaration.

The new default is to cache the menu:

• Cache the simplemenu variable

It is also to put the simplemenu variable in the header rather than the footer:

• Scope of simplemenu variable

I would try to play with those two flags to see whether I'd get the same results as 1.4.

Also, you should verify that you indeed get the JS file with the simplemenu variable under:

drupal-path/sites/your-site/files/js/simplemenu-*.js

The * represents the md5() of the content of the file.

If you edit the simplemenu.admin.inc and change all the fieldset '#collapsible' => TRUE entries with FALSE instead, that should at least give you access to the settings.

The fieldset uses JavaScript, and if it appears after the simplemenu variable that fails it would indeed stop working.

Thank you.
Alexis

As a side note, the fix that you referenced in your first post is still in the software. It appears in the simplemenu_enabled() function itself which is much more sensible since that way anyone calling the function gets the same result.

Thank you.
Alexis

Okay, I added a test in the JavaScript so if the simplemenu variable is "undefined" I exit the JS. That means you won't get the Simplemenu (obviously) but then we should be able to test all the options without having to tweak anything else.

Thank you.
Alexis

P.S. new -dev version available in 12h.

I think related or the same bug, we discovered that after installing SimpleMenu 6.x-1.7, using insert 6.x-1.0-beta4 http://drupal.org/project/insert results in an empty image tag inserted in the textarea. Taking a clue from this issue, downgrading to SimpleMenu 1.4 allows insert to function normally. I've cross posted at the insert issue queue http://drupal.org/node/622630#comment-3153246, since this combination is new to both reports, and hopefully might be helpful.

@AlexisWilke - I didn't change the status, did you? I believe I had the issue open while you were writing your post. I'll test the new version.

The dev version has fixed the #6 bug with insert.

echoz,

Does the menu work at all for you?

I checked the JS code in insert, but they generate quite a bit of JS data too... so I'll have to run the module to see what they generate.

Thank you.
Alexis

P.S. I changed the status, you're supposed to change it back to active whenever you answer. 8-)

here we go, posting at the same time again

Hi kassissieh,

The simplemenu-*.js should be under files/js, not files. And your web server should have permission to (1) create the js folder and then (2) create the simplemenu-*.js file(s).

I thought I checked and if that failed it would revert to the old behavior automatically. I guess I need to test that better!

Thank you.
Alexis

P.S. The * represents the md5 of the file contents.

6.x-1.8 (like the last dev version) is still working fine in my tests, fixing my #6 bug report with insert.

kassissieh,

Okay! Good. So at least the files are being generated. I checked for the system cached CSS & JS and there is nothing about private anything. So I do not see why it would have any effect on Simplemenu either.

I suspect that somehow there is a syntax error in those .js files or somehow it is not loaded in the header.

Would you mind attaching one or two of them to this issue? It will include your menu (if you're worried about the contents.) This way I could see whether there is a JS error in there...

Otherwise, when you load a page that does not work with Simplemenu, see whether there is a <script type="text/javascript" src=".../simplemenu-....js"></script> entry in your page header. If you have JS compressed, then it is harder to see because there will be only one .js and the Simplemenu would be defined in that one file.

Speaking of that, it makes me think that I'm running with a Drupal core patch. Compressed JS may not work right with simplemenu without that patch. Hmmm...

Noob answer: If you go to the project page: http://drupal.org/project/simplemenu then you can subscribe to all the issues. I'm not too sure whether you can subscribe to just one specific issue by email... Otherwise, it appears in your Drupal account. But of course, that means you have to come to Drupal to have a look. 8-)

Thank you.
Alexis

Kassissieh,

I see. I re-read the info in the "File system" window. If you are to use the private file system, then the files are not visible to the outside because the system saves them in a location that is not (supposed to be) visible by Apache2. At times, I'm wondering about Drupal. This means all the cache feature offered in the Core are not accessible to you!!! I now understand how they test that part: they check the 'file_downloads' variable and see if it is PUBLIC. If not, they assume that Drupal cannot use that folder and thus no file caching available...

  $is_writable = is_dir($directory) && is_writable($directory) && (variable_get('file_downloads', FILE_DOWNLOADS_PUBLIC) == FILE_DOWNLOADS_PUBLIC);

So I will fix simplemenu that way too. It sucks though. 8-P There will be a new 6.x-1.x-dev out soon with this fix.

Thank you.
Alexis Wilke

kassisieh,

> It's not that bad.

Okay, I'll wait for someone to post a patch then.

The cache is an extension from previous versions so not having it is just reverting back to 1.0/1.1.

Thank you.
Alexis

I'll mark this as fixed for now. If someone wants the optimization for a private file folder, he/she can create a new issue.

Thank you.
Alexis