First off, I can say that the module works really well. However, I can see some potential for it including Rules Integration. Why Rules integration when it has Actions and Triggers? Well, because I want to be able to say to someone that if they have more than one active session, but less than 2 that they may need to clear their cache or something like that. Then if they have more than 2 they are automatically logged off.

CommentFileSizeAuthor
#9 session_limit-rules_integration-837962-7481712.patch6.32 KBjohnennew
#7 session_limit-rules_integration-837962-7470328.patch5.42 KBjohnennew
#5 session_limit-rules_integration-837962-6757922.patch3.7 KBjohnennew

Comments

Leeteq’s picture

Leeteq commented
Title: Rules Integration (shift away from Trigger dependency) » Rules Integration

Second that, in particular now that the trigger module is thrown out of core, and being replaced with just Rules at some point in the future.

#764558: Remove Trigger module from core
#1413214: Provide upgrade path from Trigger to Rules
http://drupal.org/project/trigger
http://drupal.org/project/rules

Leeteq’s picture

Leeteq commented
Title: Rules Integration » Rules Integration (shift away from Trigger dependency)
Version: 6.x-2.1 » 7.x-2.x-dev
Component: User interface » Code
Category: feature » task
Priority: Normal » Major
Leeteq’s picture

Leeteq commented
Title: Rules Integration » Rules Integration (shift away from Trigger dependency)

FYI - Parallel discussion in Autologout module, I refer to this issue in comment #11 there:
#925818: should the one session feature be removed from autologout?

bessone’s picture

bessone commented

Rules integration sounds really interesting, any update on that from the mantainer?

johnennew’s picture

johnennew commented
Status: Active » Needs review
StatusFileSize
new session_limit-rules_integration-837962-6757922.patch3.7 KB

Please find a patch attached which directly replaces trigger with rules. There is no need to have a dependency on rules with this patch.

deekayen’s picture

deekayen commented
Status: Needs review » Needs work

Why does adding Rules mean removing Trigger? Since Trigger is just a hook anyway, can't the module keep Trigger, add Rules, and drop the dependency on Trigger?

johnennew’s picture

johnennew commented
Status: Needs work » Needs review
StatusFileSize
new session_limit-rules_integration-837962-7470328.patch5.42 KB

Yeah, no need to lose the trigger hooks - here's the patch, no external dependencies. I've moved the drupal_goto on collision as well as the unpredictability of the hook ordering means that the goto can fire before trigger or rules hooks have had a chance to do anything. I wonder if it can be removed entirely.

deekayen’s picture

deekayen commented
Status: Needs review » Fixed

Added to 7.x-2.x in f4d1af9.

johnennew’s picture

johnennew commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Fixed » Needs work
StatusFileSize
new session_limit-rules_integration-837962-7481712.patch6.32 KB

backport to 6.x-2.x attached

johnennew’s picture

johnennew commented
Status: Needs work » Needs review

changing to needs review, over to you test bot ...

johnennew’s picture

johnennew commented

Committing to 6.x-2.x

johnennew’s picture

johnennew commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.