Closed (fixed)
Project:
Search 404
Version:
6.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Reporter:
Created:
26 Jun 2010 at 05:33 UTC
Updated:
15 Aug 2011 at 13:11 UTC
Jump to comment: Most recent file
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | add-fuzzysearch-838054.patch | 2.97 KB | awolfey |
Comments
Comment #1
awolfey commentedI can provide a patch for this if you're interested. I currently have a 404 takeover in the dev version of fuzzysearch, but I think this is a better place for it.
Because fuzzy doesn't use the core search hooks, most of the patch woule lie out side of your main if statement in search404_page().
Aaron
Comment #2
akaserer commentedwow, that sounds great.
i think its a great help if fuzzy search would take over 404.
it would be usefull to be able to add an admin-setting if fuzzy search should take over 404.
thanks
Comment #3
awolfey commentedIs the maintainer interested? If zyxware want's it I can do it quickly.
Comment #4
riversidekid commentedSubscribing!
(Already using (and loving) fuzzy search, just not ready to install a .dev module.)
Comment #5
Sepero commentedAlso subscribing
Fuzzy search is a million times better than the worthless default search. I'm subscribing in the hopes that these two modules can work together. Searching with default core search is pathetic.
Comment #6
akaserer commented@awolfey :
i think it would be great if you can provide a patch.
seems like many people would need this function.
thanks
Comment #7
zyxware commented@awolfey - If you could put the patch across I could set 404 to use fuzzysearch
Comment #8
awolfey commentedzyxware, sounds good. I'll put it on my list.
Comment #9
zyxware commented@awolfey - Are you still interested in doing this?
Comment #10
zyxware commented@awolfey - Please assign this issue back to search404 with your answer.
Comment #11
awolfey commentedMy apologies, I have become very busy with work. I do still have this on my list to do. I'm also willing to help anyone else who wants to do it.
Comment #12
awolfey commentedHere's a patch. A couple of issues to deal with eventually:
1. search404 requires core search module, but people using fuzzysearch probably aren't using core search. Maybe there needs to be some kind of check that ensures at least one search module is enabled, without dependencies in the .info file.
2. Because of the above, there is some small amount of duplicated code in the patch.
3. I did this the easy way :), so jump to first or only result only works with core search.
Comment #13
WickedJ commentedSubscribing
Comment #14
zyxware commentedCommitted to latest dev version.
@awolfey - Points noted.
Is there a way to invoke
for fuzzy search to get results? If so we could implement item 3 as well.
Comment #15
awolfey commentedThere isn't now, although I've planned something like that when I get time. I'll update here, but don't hold your breath.