In the current 1.x-dev, the _skinr_add_file creates wrong filepaths, as $filename is reused in the foreach.

Especially this is a problem, when a subtheme adds new scripts, so the path will built like sites/all/themes/bastheme/sites/all/themes/subtheme.

There is a patch attached, that uses a separate $file variable, that builds in the foreach. This fixes the bug.

CommentFileSizeAuthor
skinr-_skinr_add_file.patch956 bytesderhasi

Comments

smk-ka’s picture

smk-ka commented
Status: Needs review » Reviewed & tested by the community

Confirming, the generated filenames when working with a subtheme look like this:

sites/all/themes/base-theme/styles/skinr.css
sites/all/themes/sub-theme/sites/all/themes/base-theme/styles/skinr.css

Patch works as advertised.

jacine’s picture

jacine
she/her
Location New York
commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Reviewed & tested by the community » Needs review

Thank you Johannes & Stefan! :D

Committed!

I'm not sure if this is a problem in the 6.x-2.x branch, so I'm going to keep this open in that queue until someone can check it out.

jacine’s picture

jacine
she/her
Location New York
commented
Priority: Normal » Critical
moonray’s picture

moonray commented
Status: Needs review » Fixed

This is not an issue in the 2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.