Breadcrumbs incorrect

All right,

I don't think I understood how this module was supposed to be used and somehow messed up some categories and taxonomy for the groups I had. I can't seem to get things back to normal either, I may disable this module, try to manually clean out the database, install the latest version you just posted, and try again. The alternative is to wipe out the groups I set up completely and then starting over... I'm doing this all on a test server, so no biggie.

Will report back after I do all that to see if I'm still having breadcrumb problems.

thanks,
Patrick

Sure I can wait, I just tried reinstalling the package and clearing out the fields in the og_galleries table, then setup everything again, but the breadcrumbs are still behaving strangely.

I've got a separate question around usability and categories that I'll post as a separate issue, though it's possible that's it is related.

By the way, by nature writing about issues can make one sound sound unappreciative, so I'd just like to say, thanks so much for developing this module!!

cheers,
Patrick

Hi,

I did as you suggested, downloaded the update and used it to clear out the module and tables, but after setting everything up again (adding the view and going to each group so that a group gallery would be created) creating images in a group still ends up with the same behaviour, with the breadcrumb pointing to the wrong place.

If you're working on a number of updates to og_galleries, you can take your time on dealing with this issue, since I'm only using it on a test site and haven't been able to nail down exactly where the problem is. If I can get a better understanding of how breadcrumbs are built I could probably offer more help too.

thanks again,
Patrick

Is this a new version of the patched og_views.inc?

Because I followed that thread and your project page discussions before installing og_galleries for the first time and had patched og_views.inc with the latest patch listed in the thread (og_views.inc_1.patch).

I tried doing a diff on the version you attached here and the patched version I was running with, but diff was getting caught up in some filesystem format differences (the attached one is listing as a DOS file and the diff is showing ^M for each line).

Still, replacing with what you've attached the behavior remains the same. It's still possible there's some legacy screw up I have in here from before that just isn't going away. I tried removing the galleries again and then setting them all up again, but I haven't tried removing all my groups and starting from scratch yet. That would be the next step to try. I assume you haven't been able to replicate the problem yourself.

thanks,
Patrick

Well,

that didn't do what I wanted it do.... I deleted all of my groups and deactived og and all og_related modules, looked in the database to make sure the tables were clear and then re-added the modules.

I went through the setup for og_galleries, added some new groups, and then posted images to those groups. I now get the following warnings and error when I access images (and sometimes when I access the gallery page itself)

    * warning: Invalid argument supplied for foreach() in /home/donohues/public_html/bop/modules/node.module on line 359.
    * warning: implode() [function.implode]: Bad arguments. in /home/donohues/public_html/bop/modules/node.module on line 363.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.moderate, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in /home/donohues/public_html/bop/includes/database.mysql.inc on line 120.

Does that look familiar to you and if so can you point to me where I might have done something wrong? Other than removing and adding back in the modules I've done nothing else and those messages are not very specific.

thanks,
Patrick

All right, after much back tracking, module disabling and reenabling I was able to get the error message to go away, what wonderful ways I am discovering to crash drupal...

Now here's my dumb (potentially revealing) question for the day.

Do you use the image_gallery module? I think it comes with image and is described as "Allows sorting and displaying of image galleries based on categories".

Another potentially revealing question...

Do breadcrumbs come up when your viewing the image node itself
OR
when you are just viewing the galleries either at site.com/drupal/galleries (breadcrumbs being Home >> Galleries) or at site.com/drupal/galleries/x/y (breadcrumbs being Home >> Galleries >> GroupZ)?

I was seeing breadcrumbs in all those situations, when viewing the image, when viewing a particular group gallery, and when viewing all the users galleries. The breadcrumbs were linking to the wrong places though.

I have a hunch that problems have had something to do with having the image_gallery module enabled at one point or another. I think the image_gallery functionality messes with the og_gallery functionality, but I'm not sure. I guess I had just assumed it was needed or had just left it enabled. I don't remember reading you couldn't have both on at the same time, but I've missed things before...

Could that be the problem?

Patrick

Hi,

the breadcrumb seems to be working fine when I'm looking at the galleries pages, but a breadcrumb is still coming up on the image node itself and it's incorrect. See the attached image.

This image node is in the Main gallery of the BoP Protocol Commons group, yet it's listing a breadcrumb that says it's in the 2005 Protocol Design Workshop sub-gallery of the Main gallery. The links are incorrect too, in this image node, BoP Protocol Commons points to /drupal/galleries/55, Main points to /drupal/galleries/55/75, and 2005 Protocol Design Workshop points to /drupal/galleries/55/80 but the BoP Protocol Commons gid is 51 not 55.

Of course, I'm not even sure there should be a breadcrumb trail in the image node at all... is this an og module problem?

Patrick

All right,

I may have tracked part of this down, the part that was making the link of the breadcrumb wrong

in your implementation of nodeapi

Note that you set $gid with a call to og_galleries_get_gid();

    case 'view':
      
      if (in_array($node->type, og_galleries_get_types())) {
        
        // get the gid for the current group context
        $gid = og_galleries_get_gid();
        // find the vid that matches it
        $vid = og_galleries_get_group_vid($gid);

But then you have a foreach loop that uses $gid as the key

        // figure out which vocabs are allowed to this user
        $galleries = og_galleries_get_vids();
        $allowed_groups = array_keys($user->og_groups);
        $allowed_vids = array(0);
        foreach ($galleries as $gid => $gvid) {
          if (in_array($gid, $allowed_groups) || $gid == 0) {
            $allowed_vids[] = $gvid;
          }
        }

So at the end of this, $gid may no longer have the same value as when you set it to og_galleries_get_gid() in the beginning, right? It could be referrring to a group other than the current group context, a gid of one of the other galleries.

This would be a problem when you later adjust the breadcrumb

        if ($page && $_SESSION['og_galleries']['base_tid']) {
          
          // if this is a page, adjust the breadcrumb
          $vocabulary = taxonomy_get_vocabulary($vid);
          $breadcrumb = array(array('path' => og_galleries_get_term_path($gid, ''), 'title' => $vocabulary->name));

So I changed the original foreach statement to use a different variable name than $gid as its key (in my case I just used $ggid) so that $gid would still retain the id of the current group context and the breadcrumb links are now pointing to the correct gids. Yay!

However, I still have the weird behavior seen in the last post's image where I am looking at an image in the gallery "Main" but the breadcrumbs are listing it as part of Main's subgallery "2005 Protocol Design Workshop". Further investigation shows that last breadcrumb term is showing up in images of other groups galleries too! See the attached image and note that "2005 Protocol Design Workshop" is part of the breadcrumb, even though that gallery is not in the "ESW & SGE" group galleries at all!

I'll look at this some more, something may be happening when you're traversing the parents array.

Patrick

Sorry, something seemed to go wrong with that last screenshot I attached, here's another try.

Patrick

All right, I may have tracked down the second problem too. This may be a bug from changes you made from version 1.1.2.6 to 1.1.2.7

Again in your nodeapi implementation for 'view'

You iterate through the node's taxonomy terms, and among other things you try to "use first term in the group context as the base tid for the breadcrumb"

        foreach ($node->taxonomy as $tid => $term) {
          if (in_array($term->vid, $galleries)) {
            if (!in_array($term->vid, $allowed_vids)) {
              // unset any gallery terms that shouldn't be seen by current user
              unset($node->taxonomy[$term->tid]);
            } 
            elseif ($term->vid == $vid && !isset($_SESSION['og_galleries']['base_tid'])) {
              // use first term in the group context as the base tid for the breadcrumb
              $_SESSION['og_galleries']['base_tid'] = $term->tid;
            }
          }
        }

You store the base tid in a session variable.
$_SESSION['og_galleries']['base_tid'] = $term->tid;

I think the problem comes in because the session variable can carry over to image views for other groups and may not be cleared out, because you only set a new one when an old one has not already been set.
elseif ($term->vid == $vid && !isset($_SESSION['og_galleries']['base_tid']))

That session variable for the tid is then used for the breadcrumb trail in the following code.

Does that sound accurate?

In version 1.1.2.6 you did this with a variable called $crumb_tid, is there a reason you switched over to using a session variable?

As an attempted fix, what I did was to create a local variable $base_tid_set for the conditional, but still stored the base_tid in a session variable.

        $base_tid_set = 0;
        foreach ($node->taxonomy as $tid => $term) {
          if (in_array($term->vid, $galleries)) {
            if (!in_array($term->vid, $allowed_vids)) {
              // unset any gallery terms that shouldn't be seen by current user
              unset($node->taxonomy[$term->tid]);
            }
            elseif ($term->vid == $vid && !$base_tid_set) {
              // use first term in the group context as the base tid for the breadcrumb
              $_SESSION['og_galleries']['base_tid'] = $term->tid;
              $base_tid_set = 1;
            }
          }
        }

That way the session variable is still being set (in case you had something else in mind globally that needed it) but the conditional is tested locally. With that fix I appear to be getting the correct behavior.

thanks,
Patrick

Oh, one more thing, I'm not sure if you agree with this change to the breadcrumbs, but let me know what you think.

For the image I attached previously the now correct breadcrumb would be:
Home >> ESW & SGE >> Main

But I think I prefer having galleries also in the breadcrumb, so it's a little more obvious that the image is part of a gallery... so it instead would be
Home >> galleries >> ESW & SGE >> Main

This also makes it look more in line with the views pages where the breadcrumbs are
Home >> galleries
Home >> galleries >> ESW & SGE

To do this I just changed

$breadcrumb = array(array('path' => og_galleries_get_term_path($gid, ''), 
'title' => $vocabulary->name));

to

$breadcrumb = array(array('path' => og_galleries_get_url(), 'title' => t('galleries')), 
array('path' => og_galleries_get_term_path($gid, ''), 'title' => $vocabulary->name));

Patrick