Posted by rjung on September 13, 2006 at 12:48am
Jump to:
| Project: | Easylinks |
| Version: | 4.7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | rjung |
| Status: | closed (fixed) |
Issue Summary
Downloaded easylinks.module 1.5.2.1 2006/08/19 last night, and noted that it did not properly update links after an edit (changing descriptions, changing link state, etc.).
The bug is in the incorrect sequence of fields for the database UPDATE call. The function easylinks_update() should be changed as follows:
function easylinks_update($linkdata) {
db_query("UPDATE {easylinks} SET state = %d, url = '%s', sitename = '%s', sitedesc = '%s' WHERE lid = %d", $linkdata['links_state'], $linkdata['links_url'], $linkdata['links_sitename'], $linkdata['links_sitedesc'], $linkdata['links_lid']);
}
Comments
#1
Patch was applied.
The update process worked correctly on fresh installation, but rather clean code makes things easier. easylinks.install fixed too(missing ' [single quote]).
Thanks.
#2