comment.load and comment.loadNodeComments should invoke hook_comment on the comments they load [#839000]

Both comment.load and comment.loadNodeComments currently return the raw column data from the database query in _comment_load(). Contrib modules can add information to the comment object inside hook_comment's "view" operation, however this hook isn't currently being called by either of the Services API functions.

Attached is a patch that modifies both Services API functions to pass each comment through hook_comment prior to returning it.

Comment	File	Size	Author
#2	comment_service-invoke-01.patch	833 bytes	smokris
	comment_service-invoke-00.patch	783 bytes	smokris

Comments

Comment #1

28 June 2010 at 00:00

Status:

Needs review

» Needs work

The last submitted patch, comment_service-invoke-00.patch, failed testing.

Comment #2

smokris

Athens, Ohio, USA

commented 28 June 2010 at 02:18

Status:

Needs work

» Needs review

Status	File	Size
new	comment_service-invoke-01.patch	833 bytes

(Fix relative directory in patch.)

Comment #3

skyredwang

Shanghai

commented 13 August 2010 at 20:51

Status:

Needs review

» Closed (works as designed)

hmmm. This is a good question. Comment services just pass the information to Drupal comment API. I noticed that comment_save() invoke contrib modules, but _comment_load() doesn't. see http://api.drupal.org/api/function/_comment_load/6

I would mark this as 'by design'

Comment #4

mradcliffe

he/him

English

commented 29 September 2010 at 21:04

Version:	6.x-2.2	» 6.x-3.x-dev
Category:	bug	» feature
Status:	Closed (works as designed)	» Needs work

Why would you mark this 'by design'? It seems to be more of a feature request to allow comments to be modified by contrib modules. Why would you limit the comment service to just what's in core? That doesn't make any sense to me.

I think the patch needs work, and should be bumped to 6.x-3.x-dev for development as a feature request.

For instance the old way returns an array of comments, but the patch just returns one comment. The patch should maintain the API. I'll try writing a patch for the next version.

Comment #5

kylebrowning commented 11 December 2010 at 17:41

Assigned:

Unassigned

» kylebrowning

Comment #6

skyredwang

Shanghai

commented 12 December 2010 at 00:04

Status:

Needs work

» Closed (works as designed)

Services is only responsible for exposing existing core APIs in a standard way. Services module will not create "new" functions. If the Drupal core doesn't provide the comment functions that you need, you can write your own custom services. Or, you can file feature request to Drupal Core. This is marked as "by design".