Retrieve state/province and city/suburb information from google geocoding where available

I've created a new instance of drupal and installed location (no gmap this time) plus the two patches.
Created two nodes with full addresses, both geocoded fine as far as lat/lon goes but nothing in zipcodes, kinda thought it might put the finds there. One UK and one US address. I think I will drop some dd() in there and see what is going on.

BTW I see in the location table that column source has 3 in it, not sure what that means as yet so that's another thing to get a grip on.

I enabled google in admin/settings/location/geocoding for UK, US, Germany and Australia, I might try just postcodes next.

Subscribing, greetings, Martijn

Using uk postcodes and having made sure nothing in location.uk.inc would jump in, I found that rough and rough_default were never being reached, location_latlon_exact was being called in _location_geo_logic from location.module. Haven't traced that back yet. I'm using location enabled nodes to test this all.
More later...

@rooby:
On saving a node, location_save() runs location_latlon_exact() via _location_geo_logic() which only saves lat/lon. There is a comment in location.module line 1324 // @@@ How about address normalization?
This suggests that this would be a good place to add city and state, so I added

        if ($data['city']) {
          $location['city'] = $data['city'];
        }
        if ($data['state']) {
          $location['province'] = location_province_code($location['country'], $data['state']);
        }

I now am saving province to the location table when I supplied country and postcode only. 'city' was not supplied by google in this particular instance. I only ran one test on UK postcode. I will try some other countries too.

rant start
UK postcodes are a pain because they are in two parts and the Royal Mail are being despicably duplicitous, insisting on the right to sell data already paid for by the taxpayer ;-| grrrrrr. Oh well
rant end

Now none of this addresses the original idea of saving geocode stuff to zipcodes table.
I would suggest some new functions: (in location.inc)
1) location_insert_zipcodes
2) location_update_zipcodes
3) a handling function function which would ensure that the zipcodes table was updated sensibly, preserving existing data etc

or perhaps all three rolled into one.

3) could be called in _location_geo_logic() or perhaps even better in location_latlon_exact()

This way it doesn't matter if rough and rough_default are used or not.

Will this patch bring europe/worldwide google geocoding available to location?
Greetings, Martijn

Closing old D6 issues as D6 is end of life