The address field handler for views should return an 'element type' of 'div' so that addresses don't get wrapped in a span element.

CommentFileSizeAuthor
#4 location-DRUPAL-6--3_views_element_type2.patch554 bytesdboulet
location-DRUPAL-6--3_views_element_type.patch763 bytesdboulet

Comments

dawehner’s picture

dawehner
Primary language German
commented

I think you get set "$this->definition['element type']", too

dboulet’s picture

dboulet commented

@dereine, can you please elaborate a little more on your comment?

dawehner’s picture

dawehner
Primary language German
commented

you don't have to override the method, but you could just the the element type in your data definition.

dboulet’s picture

dboulet commented
StatusFileSize
new location-DRUPAL-6--3_views_element_type2.patch554 bytes

Right, that makes sense, thanks dereine.

Does this patch look right?

dawehner’s picture

dawehner
Primary language German
commented

Yes he does.

yesct’s picture

yesct commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Location theming

I think this is ready to be checked by a maintainer.

I wonder if looking at old issues might help.... adding a tag that might yield other issues to look at.

rooby’s picture

rooby commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch.
Committed to 6 & 7.

http://drupal.org/cvs?commit=387912
http://drupal.org/cvs?commit=387910

Status: Fixed » Closed (fixed)
Issue tags: -Location theming

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Location theming

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.