Dear Ber,

There is an idea to support separators for buttons (because quite a lot of modules will be using quicktags soon).
Instead of passing 

  $items['ed_block'] = array(
      'name' => 'quote',
      'prefix' =>'[quote]',
      'suffix' => '[/quote]',
      'accesskey' => 'q',
      'icon' => $path .'ed_block.png',
    );

we will pass the following data:

  $items['sep1'] = array(
      'type' => 'separator',
      'icon' => $path .'ed_block.png',
      'weight' => 5,
    );

Where 'type' will be the new attribute set to 'image' by default indicating that this is a normal image (button), and 'separator' will mean that this is just an image without an A-HREF tag and function call. 'weight' attribute will specify its order (hope it will be implemented soon, I saw a feature request).

What do you think ? If you agree and accept an idea, I can provide you a patch shortly.

Thanks.

Comments

Bèr Kessels’s picture

Bèr Kessels commented

I like this idea. I think, however, that we should look at a more general 'HTML code' tag. That way we can also add breaks (BR) and something like <img src="separator.png"/>, to add a separator.

ardas’s picture

ardas commented

Ber, are you going to commit weight patch provided here http://drupal.org/node/72753 ?
I'm asking because if I provide you separators patch, that one can't be applied. So, if you are going to commit it please do it, and I'll download the newest version or I can take weight patch and provide you an aggregated patch for weights and separators.

Thanks.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Active » Closed (won't fix)

This version of quicktags is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.