views_plugin_argument_default_user doesn't return UID when looking at a view that takes UID as an argument.

To reproduce, create a page view with path mypath/% that takes "User: UID" as an argument.

Create a block view that takes "User: UID" as an argument and select "User ID from URL" as the default argument type.

When looking at mypath/UID, the block from the second view doesn't appear.

The attached patch fixes this.

CommentFileSizeAuthor
#17 views-plugin-argument-default-user-17.patch865 bytesmarcp
#2 views-plugin-argument-default-user-2.patch950 bytesmarcp
views-plugin-argument-default-user.patch1.05 KBmarcp

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs work 
+++ views_plugin_argument_default_user.inc	28 Jun 2010 20:04:42 -0000
@@ -59,6 +59,23 @@ class views_plugin_argument_default_user
+    if ($views_page && $views_page->options['arguments']) {
+      $index = 0;
+      foreach ($views_page->options['arguments'] as $name => $arg) { ¶

why are we not iterating over $views_page->arguments?

the name of an argument is to specific, we should have a look at the table/field of the argument.

Powered by Dreditor.

marcp’s picture

marcp commented
Status: Needs work » Needs review
StatusFileSize
new views-plugin-argument-default-user-2.patch950 bytes

Great point! Here's the new patch.

bonobo’s picture

bonobo commented

Any movement/word on this? This is working great for us in a few different places.

dawehner’s picture

dawehner
Primary language German
commented

Can you explain why you do this?

Default argument's are only used when Action to take if argument is not present: which is not the case here. I don't see the point why it's needed currently.

bonobo’s picture

bonobo commented

The default behavior doesn't work for blocks when using any path that isn't the standard user/uid path -

So, if you create a view with a page display that lists all posts by a user; this page can be accessed at (for example) foouserposts/uid - for the page display, the argument will filter by uid.

However, if at foouserposts/uid you wanted to display an "About the Author" block, the same argument won't work - so, while it works for a page display, it doesn't work for a block display.

This patch fixes that.

bonobo’s picture

bonobo commented

Any word here?

dawehner’s picture

dawehner
Primary language German
commented

@bonobo

Please be so fair and don't dump issues. There are 160 patches in the views issue queue which needs review.

I would perhaps check also for table == 'user'

bonobo’s picture

bonobo commented

Definitely not "dumping" the issue, and definitely not demanding anything in any way, shape, or form.

Saying "I've been busy" is a completely acceptable response, and I'm fine with that. It's been a month since there was any movement on this - we found what appears to be a bug, we supplied a patch, and we have tested that patch in a few different contexts. When you asked questions, we responded, and in the case of #2, above, rolled a new patch.

All I was doing was asking if there had been any movement on this - "no" is a perfectly acceptable answer.

While we'd like to get this rolled into views, we're perfectly capable of maintaining it on our own as well.

If there is anything we can do, please let us know. If you're not going to review the patch, that's fine too.

dawehner’s picture

dawehner
Primary language German
commented

You know the views issue queue is kind of bussy. A month is nothing here: See http://drupal.org/project/issues/views?text=&status=8&priorities=All&cat...

If there would be movement someone would have posted a comment. All this unnecessary pushing of issues is annoying.

clashar’s picture

clashar commented

subscribe,
not sure but I think I have similar problem, I use argument
"User: Uid"
- "provide default arg"
- "User ID from URL"

but devel shows "Query: No query was run"

Everything is ok, if I use for example "User ID from logged in user", but that's not what I need

clashar’s picture

clashar commented

by the way, I use 6.3 dev. and when I check - "User ID from URL", new box appears "Default argument: ", maybe I don't understand well but it is confusing for me, there will be always user id from URL why then provide box "Default argument: "

bonobo’s picture

bonobo commented

@clashar - this issue is for the 6.x-2 branch.

I'm not entirely sure what issue you are describing but it should probably be opened in a separate issue.

Also, if you can include some specific steps to replicate the issue, it will help get more focused feedback.

For example, info about your drupal version, your OS and PHP version, and any other installed modules will help.

clashar’s picture

clashar commented

I applied patch from #2 manually to 3.x.dev but it didn't help.
Sorry for so many postings, seems it's not the same issue.

bonobo’s picture

bonobo commented

@clashar - the patch in this issue is against Views 2.

You are using Views 3, so the patch won't apply.

I'm not entirely sure that the issue you are reporting is a bug, or is related to a config error, but in any case you should open a separate ticket for it.

In the absence of a patch to solve a bug, any screenshots that show the issue, along with more info about your site setup, will help you get more focused feedback.

clashar’s picture

clashar commented

bonobo, thanks for quick reply.
Often I am not yet sure if I should create a new issue, for this case I will open a new issue providing screenshots.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

My comments here http://drupal.org/node/840668#comment-3841378 apply here as well. IN short: Need a 6.x-3.x patch to merit consideration.

marcp’s picture

marcp commented
Version: 6.x-2.x-dev » 6.x-3.x-dev
Status: Needs work » Needs review
StatusFileSize
new views-plugin-argument-default-user-17.patch865 bytes

Attached is a patch for 6.x-3.x.

You can test it out quickly with the following view, which provides a page accessible at userposts/% and a block that should show up on any page where uid is an argument. Before applying the patch, the block will not appear when viewing userposts/%.

$view = new view;
$view->name = 'user_posts';
$view->description = 'Posts for a user';
$view->tag = '';
$view->base_table = 'node';
$view->human_name = '';
$view->api_version = '3.0-alpha1';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Defaults */
$handler = $view->new_display('default', 'Defaults', 'default');
$handler->display->display_options['access']['type'] = 'none';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['pager']['type'] = 'full';
$handler->display->display_options['style_plugin'] = 'table';
$handler->display->display_options['style_options']['columns'] = array(
  'nid' => 'nid',
  'title' => 'title',
);
$handler->display->display_options['style_options']['default'] = '-1';
$handler->display->display_options['style_options']['info'] = array(
  'nid' => array(
    'sortable' => 0,
    'align' => '',
    'separator' => '',
  ),
  'title' => array(
    'sortable' => 0,
    'align' => '',
    'separator' => '',
  ),
);
$handler->display->display_options['style_options']['override'] = 1;
$handler->display->display_options['style_options']['sticky'] = 0;
/* Field: Node: Nid */
$handler->display->display_options['fields']['nid']['id'] = 'nid';
$handler->display->display_options['fields']['nid']['table'] = 'node';
$handler->display->display_options['fields']['nid']['field'] = 'nid';
$handler->display->display_options['fields']['nid']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['nid']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['nid']['alter']['trim'] = 0;
$handler->display->display_options['fields']['nid']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['nid']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['nid']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['nid']['alter']['html'] = 0;
$handler->display->display_options['fields']['nid']['hide_empty'] = 0;
$handler->display->display_options['fields']['nid']['empty_zero'] = 0;
$handler->display->display_options['fields']['nid']['link_to_node'] = 0;
/* Field: Node: Title */
$handler->display->display_options['fields']['title']['id'] = 'title';
$handler->display->display_options['fields']['title']['table'] = 'node';
$handler->display->display_options['fields']['title']['field'] = 'title';
$handler->display->display_options['fields']['title']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['title']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['title']['alter']['trim'] = 0;
$handler->display->display_options['fields']['title']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['title']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['title']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['title']['alter']['html'] = 0;
$handler->display->display_options['fields']['title']['hide_empty'] = 0;
$handler->display->display_options['fields']['title']['empty_zero'] = 0;
$handler->display->display_options['fields']['title']['link_to_node'] = 1;
/* Field: User: Name */
$handler->display->display_options['fields']['name']['id'] = 'name';
$handler->display->display_options['fields']['name']['table'] = 'users';
$handler->display->display_options['fields']['name']['field'] = 'name';
$handler->display->display_options['fields']['name']['label'] = 'Author';
$handler->display->display_options['fields']['name']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['name']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['name']['alter']['trim'] = 0;
$handler->display->display_options['fields']['name']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['name']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['name']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['name']['alter']['html'] = 0;
$handler->display->display_options['fields']['name']['hide_empty'] = 0;
$handler->display->display_options['fields']['name']['empty_zero'] = 0;
$handler->display->display_options['fields']['name']['link_to_user'] = 1;
$handler->display->display_options['fields']['name']['overwrite_anonymous'] = 0;
/* Argument: User: Uid */
$handler->display->display_options['arguments']['uid']['id'] = 'uid';
$handler->display->display_options['arguments']['uid']['table'] = 'users';
$handler->display->display_options['arguments']['uid']['field'] = 'uid';
$handler->display->display_options['arguments']['uid']['default_action'] = 'default';
$handler->display->display_options['arguments']['uid']['style_plugin'] = 'default_summary';
$handler->display->display_options['arguments']['uid']['default_argument_type'] = 'user';
$handler->display->display_options['arguments']['uid']['default_argument_options']['user'] = TRUE;
$handler->display->display_options['arguments']['uid']['break_phrase'] = 0;
$handler->display->display_options['arguments']['uid']['not'] = 0;

/* Display: User post page */
$handler = $view->new_display('page', 'User post page', 'page_1');
$handler->display->display_options['path'] = 'userposts/%';

/* Display: User post block */
$handler = $view->new_display('block', 'User post block', 'block_1');
$translatables['user_posts'] = array(
  t('Defaults'),
  t('more'),
  t('Apply'),
  t('Reset'),
  t('Sort By'),
  t('Asc'),
  t('Desc'),
  t('Items per page'),
  t('- All -'),
  t('Offset'),
  t('Nid'),
  t('Title'),
  t('Author'),
  t('All'),
  t('User post page'),
  t('User post block'),
);
merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed to all branches.

chuckbar77’s picture

chuckbar77 commented
Status: Fixed » Active

I upgraded from Views-6.x-2.12 to Views-6.x-2.x-dev and all my views pages that had path as user/% with argument went blank. Can this be the reason?

marcp’s picture

marcp commented

@chuckybar77 - Try starting over with your upgrade, but remove the 4 lines of code provided by the patch and see if that fixes your problem.

Looks like you need to run update.php after upgrading from 6.x-2.12 to 6.x-2.x-dev also, so you might try that first.

merlinofchaos’s picture

merlinofchaos commented

If your pages are blank, check the php error log.

Letharion’s picture

Letharion commented
Status: Active » Fixed

Issue was fixed, and then incorrectly re-opened.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.