Hey,
First I would like to say thanks for such a great module!
For the most part it works really well, however I decided to allow users to register to the site with their facebook account and in the case, they don't have a chance to check the legal checkbox to accept terms on registration and the warning doesn't appear once they are logged in. Basically they have no way of accepting the terms before they use the use the site. Is there any way to fix that?

Thanks.

CommentFileSizeAuthor
#23 legal_facebook_connect-redirect_issues-840068-23.patch7.54 KBDavid Stosik

Comments

Abeaudrian’s picture

Abeaudrian commented

Subscribing..

g.k’s picture

g.k commented

+1

nrpr’s picture

nrpr commented

+1

drupalina’s picture

drupalina commented

+1
hmm... I guess this could be circumvented if Admins has a choice "Set the legal checkbox as ticked by default" or by allowing admins another option to display a simple statement below the "Create new account" button that says "By signing on you agree to the Terms & Condition"

Jimmy McCrillis’s picture

Jimmy McCrillis commented

Any guesses when this will work for Drupal 7.x?

dmadruga’s picture

dmadruga commented

+1

carlop’s picture

carlop commented

+1

Anonymous’s picture

Anonymous (not verified) commented

I was going to have a look into this but reached a wall while registering as a developer on facebook as i needed to provide a mobile phone number (don't have at the moment) or debit / credit card details (which i won't give out to facebook)

I'll come back to this a little later

Best,
Paul Booker
Appcoast

robert castelo’s picture

robert castelo commented

Same here, anyone developing for Facebook that wants to provide a patch?

robert castelo’s picture

robert castelo commented
Status: Active » Fixed

Should work in latest version, Legal 6.8.3

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Opening again. Still doesn't work for me here. When we disable the legal module everything works again.
Will post soon with more details

robert castelo’s picture

robert castelo commented

Nick_vh what version are you trying?

I had a few reports that Legal 6.x-8.3 worked great with Facebook Connect.

tpainton’s picture

tpainton commented
Version: 6.x-2.2-beta4 » 6.x-8.5

Yes, it seems to break facebook connect. I am using latest release. :(

Alessandro Pezzato’s picture

Alessandro Pezzato commented

Legal 8.5 + Facebook Connect 3.0-rc15 give me a redirect loop when logging in, if user has not accepted T&C before

Alessandro Pezzato’s picture

Alessandro Pezzato commented
Status: Closed (fixed) » Active
tpainton’s picture

tpainton commented

Okay, I got this working but you must use the option to create account at a later time.. See docs.

robert castelo’s picture

robert castelo commented

tpainton could you please provide some documentation of what setting needs configuration for Facebook Connect to work with Legal module - I'll add it to the README.txt

tpainton’s picture

tpainton commented

Hi, nothing spectacular.. All I am doing is linking accounts AFTER the user creates an account on the drupal site.. In other words, I don't create the user account as soon as they click on facebook connect.

In facebook applications, click edit, click on Facebook User Settings, Click on "Do not create accounts Automatically". Then, when user DOES create account, it runs them through the Legal agreement.

robert castelo’s picture

robert castelo commented

Thanks tpainton, I've added that to the README.txt, which will be included in the next release.

robert castelo’s picture

robert castelo commented
Status: Active » Closed (fixed)
David Stosik’s picture

David Stosik commented
Status: Closed (fixed) » Active

Hello,

This is not a fix. As soon as I update the legal terms, and want my users to approve those new conditions, I'm screwed. All Facebook account will be asked to check the new conditions and enter the facebook connect/legal infinite redirect loop.
Instead of logging-out then redirecting the user, why not check in hook_init if user accepted terms, and redirect to the accept form in here, without logging him out?

Regards,
David

Edit: by the way, wouldn't proceeding in hook_init() also ensure that users who stayed logged-in when conditions changed get the new conditions checkbox?

David Stosik’s picture

David Stosik commented
Version: 6.x-8.5 » 6.x-8.x-dev
Status: Active » Needs work
StatusFileSize
new legal_facebook_connect-redirect_issues-840068-23.patch7.54 KB

Here is a patch I wrote to illustrate what I wrote in comment above.
This probably needs refinement, but may be an interesting start.
DO NOT USE ON PRODUCTION SERVER YET!

If someone who knows legal module well could tell me what he thinks about my patch, that would be very appreciated.

Thanks,

David

David Stosik’s picture

David Stosik commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, legal_facebook_connect-redirect_issues-840068-23.patch, failed testing.

marty.true’s picture

marty.true commented

Any progress on this patch or latest version? This is pretty much a "deal killer" for using this module... In today's times, if your site doesn't connect with FB, you are pretty much behind the times...

Infoloko’s picture

Infoloko commented
Issue summary: View changes

I agree 100% with #26 .. I want to use Legal Accept but having FB logins going to a redirect loop is totally unacceptable . Until fixed I'm going to have to disable this module

just discovered that having tried to login via FB (and hit the redirect problem), ALL subsequent attempts to login using '/user/login' from any user including admin hit a redirect loop. Deleting all cookies allowed me to login again

  • Robert Castelo committed 1d219fe on 7.x-2.x 
    Issue #840068 by tpainton: Doesn't work with facebook connect - added...
robert castelo’s picture

robert castelo commented
Status: Needs work » Closed (outdated)

No longer supporting Drupal 6 version of Legal, so closing this old issue.