If I have a percent discount, then it applies to both the product and the attribute adjustments.
Example:
My discount is 20%, ie "* -0.2" in the discount settings (yes this is wacky: #492114: improve UI for percent discounts but it works).
Suppose a product price is $100. There is a single attribute with one option which adds $100.
When I add the product to my cart with this option, the cart price correctly shows as $160.
But on the product node, I see a base price of $80 with an option for $100. This is wrong and misleading to the customer.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 840208-3.uc_discount.option-labels.patch | 1.9 KB | joachim |
| #2 | 840208-2.uc_discount.option-labels.patch | 1.63 KB | joachim |
| #1 | 840208_attribute_option.patch | 392 bytes | Island Usurper |
| #1 | 840208_attribute_discount.patch | 735 bytes | Island Usurper |
Comments
Comment #1
Island Usurper commentedSo, this requires a change to both uc_discount and uc_attribute to work properly. uc_discount needs to handle the 'attribute_option' type, and uc_attribute needs to provide the node in the $context.
Comment #2
joachim commentedUC Discount needs a little bit more than that: discounts whose methods is 'add' rather than 'multiply' must not alter the option prices, so uc_discount_get_discount() needs a way of knowing it's altering an option.
Here's a patch with that (against my SVN, may be a little fuzzy).
Also, node/XX/edit/attributes dies in all cases, and so needs the $context['subject']['node'] as well. Island Usurper, could you look at that please -- you're likely to be much quicker than me at finding the right place for that.
Comment #3
joachim commentedTrying to debug the crash on the node/XX/edit/attributes....
Why does the node display get $context['revision'] = 'formatted', but the node/XX/edit/attributes page get $context['revision'] = 'themed'? This is what I meant needs explaining at #449546: uc_price() is a new complicated thing and needs explaining...
Also, I'm not sure how best to fix this.
Trivially, uc_object_attributes_form() can add the $node to the context, but when it's a class attribute form, that's not possible.
Also, when you think about it, the node/XX/edit/attributes page *shouldn't* show the discounted price. It's an admin page, and you need to be able to see what's what.
So uc_discount_price_handler_alter could simply test for the presence of a $node in the context.
Here's an updated version of my patch in #2 with that. (On my local SVN, may have fuzz.)
However -- are there any other cases where we'd get to uc_discount_price_handler_alter case 'attribute_option' without a $node?