Hi having used apachesolr 1.0 for a long time untill now without problems in Drupal 6.X. Now i have activated some taxonomies and if i now search something (no matter if it is a normal word from a text or a used taxonomy term i get the following error with 1.0:

warning: implode() [function.implode]: Invalid arguments passed in /path/to/drupal/sites/all/modules/apachesolr/apachesolr.module on line 2003.

with the newest 2.0-dev it is:
warning: implode() [function.implode]: Invalid arguments passed in /path/to/drupal/sites/all/modules/apachesolr/apachesolr.module on line 2121.

CommentFileSizeAuthor
#6 840358-invalid-implode-6.patch965 bytespwolanin

Comments

pimok3000’s picture

pimok3000 commented
Title: Error searching Taxonmies » Error searching Taxonomies

BTW the error results are still showing, but this error is displayed above of them

pwolanin’s picture

pwolanin commented

If this bug is in 6.x-1.x, let's fix it there first.

However, apachesolr.module does not have 2003 lines in the file in 6.x-1.0 - it only has 1683. Please check whether your code base is intact or has been hacked.

In 6.x-2.x the relevant implode seems to be:

2121:    $settings['apachesolr_show_more_blocks'] = implode(', ', $show_more_selector);
pimok3000’s picture

pimok3000 commented
Status: Active » Fixed

Having tested the system for 4 days now with line 2121 commented out has no visible side effects and none of the functionality has been influenced in any way. If this error pops up again i will reopen this issue but for now, at least for me , it is closed.

pimok3000’s picture

pimok3000 commented
Status: Fixed » Closed (fixed)
jpmckinney’s picture

jpmckinney commented
Status: Closed (fixed) » Fixed

Please leave tickets in fixed status. The bot will set them to closed in time.

pwolanin’s picture

pwolanin commented
Status: Fixed » Needs review
StatusFileSize
new 840358-invalid-implode-6.patch965 bytes

This is a real (but simple) bug - here's a possible patch.

robertdouglass’s picture

robertdouglass commented
Version: 6.x-2.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

#840358 by pwolanin | torstenzenk: Fixed Error searching Taxonomies.

Applying #6 to 6.2.

jpmckinney’s picture

jpmckinney commented

Applied empty -> is_null change to 7.x.

pwolanin’s picture

pwolanin commented

actually, for Drupal code we often prefer !isset() to is_null() for this kind of test.

jpmckinney’s picture

jpmckinney commented
Status: Patch (to be ported) » Fixed

apachesolr_js and show_more_selector don't exist in 1.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.