on Drupal head/5.0, go to ?q=admin/build/menu.
you cannot enable the menu items (the menu id is negative).
This issue also exists in 4.7.

Comments

Bèr Kessels’s picture

I cannot reproduce in 4.7. The module is not yet 5.0 compatible.

beginner’s picture

Priority: Critical » Normal

Sorry, it's not critical since you can manually create a menu item to the proper link.

But I can reproduce on both my 4.7 and 5.0 sites.
the 'enable' link for a chunk links to the path "admin/menu/item/edit/-208 " which is not valid.
It is either a tagadelic issue or also probable a core issue.
Beside a custom module that has nothing to do with it, tagadelic is the only contrib module on my remote 5.0 site.

abqaria’s picture

i got the same problem, i am using 4.7.4

i cannot enable it
but what is the correct path ?

Bèr Kessels’s picture

The problem is, that I cannot reporoduce. I am not saying that, because I cannot reproduce the bug is invalid. But I cannot fix something that 'just' works, here.

I would like to hear what a menu reset does, if that fixes the issue (backup backup).

basicmagic.net’s picture

hi ber-

thanks for such a great module.

and yes- i understand that if you can not duplicate the issue-
its hard to fix.

i just did want to say that i am experiencing this same issue-
running drupal 4.74.

meaning by default-

all menu items generated by tagadelic have a negative value-
and are not enabled-

so when you go to try to enable them-
the menu item can not be found.

interesting enough- the main 'tags' menu item-
can be enabled-
but again none of the sub- menu items for other tags.

will try the menu reset and see if that fixes it.

just wanted to report in that this is indeed a live issue-
i have been very careful with my install of drupal 4.74 and it seems
this issue is present regardless of anything else.

vincent

tidalx3’s picture

I have the same problem, trying to enable the tag menu or going to its menu edit pagge shows page not found

csc4’s picture

have the same problem - 4.7.2, have tried downloading the latest version and running update.php, tried menu reset no change.

MySQL 5.0.23
PHP 5.2.0

The other thing I've noticed is that the tags menu option is the highest mid I have in my table (in my case 529). The negative children range from -843 to -870.

I also can't seem to find the menu options searching in PHPmyadmin for title which seems most strange.

Bèr Kessels’s picture

please do not post anymore -I have this problem too- followups. I know the problem obviously is there. All I need is someone who encouters the bug to fix it :)

As I said: I have never encoutered it, hence I cannot fix it.
(I have never said: I have not encountered it, so it does not exist!)

csc4’s picture

Not sure what you mean about not posting any more.

If I could fix the bug I would but I'm a relative newbie struggling to understand where the menu options are defined.

More searching turned up 40879#comment-125828 which suggests the numbers are negative because they're not in the database and also suggests it's to do with the naming? Maybe nevets can shed more light?

Bèr Kessels’s picture

not posting any more "I can confirm this" is what I meant. I know the problem is there. I now need action; code and debuggers. Not people telling they also see the problem :)

csc4’s picture

Does the information from nevets about the negative numbers in the post referenced above not help?

Bèr Kessels’s picture

Again: I don't need people confirming or chiming in. I need people to debug it, and to create a patch :). "scratch your own itch".

john morahan’s picture

Status: Active » Needs review
StatusFileSize
new520 bytes

If you can't reproduce this on an existing installation, try a fresh installation instead - if any of the relevant menu items have already gotten saved somehow, this problem doesn't occur. They don't get saved automatically because they don't have a valid parent id, since their parent is a MENU_CALLBACK.

One possible fix would be to change the parent to MENU_SUGGESTED_ITEM.

In the meantime anyone who is having this problem can fix it by manually creating a menu item for tagadelic/chunk (it can be deleted afterwards, it just needs to get saved once).

beginner’s picture

Status: Needs review » Reviewed & tested by the community

John, you are my hero for the day (and even longer!)
Thanks for taking the time to track back the bug.

Patch applies with a tiny offset.
Most importantly, it does solve the problem!

Having a MENU_SUGGESTED_ITEM seems indeed to be the right approach.

john morahan’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new661 bytes

The trouble with this is that it adds an extra unnecessary "Tags" item to the menu administration page, for tagadelic/chunk.

A possibly better approach: remove the menu item for tagadelic/chunk entirely. As an added bonus this also fixes the breadcrumbs to display "Home › Tags" instead of "Home › Tags › Tags".

csc4’s picture

Thanks John - great detective work and really helpful.

Much appreciated. Hope the patch gets committed soon!

Bèr Kessels’s picture

I don't have time to test and review this in depth. It looks good. And if it solves the problem, I am willing to commit.
One question though:
Can someone paste a summary of the paths after this patch?
/tagadelic -> shows XX
/tagadelic/foo -> shows bar
/tagadelic/bar -> shows bar in a list

etc.

I want to fix this, but not at the cost of giving many people 404-s because of changed urls, nor at the cost of loosing the advanced url arguments manipulation (lists, combined chunks etc).

john morahan’s picture

Here's what I get, with the patch. These are all the same as what I get without the patch, including the page not found at tagadelic/list.

'tagadelic' -> tag cloud showing terms from all vocabs
'tagadelic/chunk' -> tag cloud showing terms from all vocabs
'tagadelic/chunk/1' -> tag cloud showing terms from vocab 1
'tagadelic/chunk/1,2' -> single tag cloud showing terms from vocabs 1 and 2
'tagadelic/list' -> page not found
'tagadelic/list/1' -> "list" containing a single tag cloud for vocab 1
'tagadelic/list/1,2' -> list of tag clouds for vocabs 1 and 2

This works because tagadelic_page_chunk() reads its argument directly from arg(2), so we can remove the explicit menu item and fall back to 'tagadelic', which has the same callback, without having to worry about the callback arguments (as there aren't any).

Bèr Kessels’s picture

Status: Needs review » Reviewed & tested by the community

Then this patch can go in. thanks. I need to find time to commit it, so please be patient.

Anonymous’s picture

ping. Just a cherry reminder. ;t

Bèr Kessels’s picture

Status: Reviewed & tested by the community » Fixed

Fixed in HEAD of the 5.x branch.
thanks for the patch, and even more thanks for the testing. Testing patches is the only way to fix bugs faster! :)

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.