Upgrade to 5.0

I need some reviews, since I don't use any 5.0 sites yet.

Please test the code, and check the install/info system too.

- removed case 'admin/modules#description' from hook_help, looks like it's no longer needed with .info files
- made menu callbacks use function arguments instead of arg()

Keeping it up to date

I am holding this off, until:
* The branch for 5.0 is made ready.
* Core is more stable.
* We have more bugs fixed.

I want to prepare a new (bugfree) release for 4.7 first, then branch that off to 5.0. Until today, HEAD tagadelic has lots of nice new features /and/ works on 4.7.

- made menu callbacks use function arguments instead of arg()

This is a different isseu, please remove.

Also: in future please be aware of spaces. Your patch contained some spaces on the end of the lines. This makes it harder to read, because the patch contains differences due to these spaces.

+      '#default_value' => isset($voc) ? variable_get('tagadelic_block_title_'. $delta, t('tags in %voc', array('%voc' => $voc->name))) : '',

Is this needed for an upgrade to 5.0?

 /**
- * Implementation of hook_settings
+ * Menu callback. Admin setting page for tagadelic.
  */
 function tagadelic_settings() {
+  return drupal_get_form('tagadelic_settings_form');
+}
+ 
+/**
+ * Form builder for the tagadelic settings.
+ */
+function tagadelic_settings_form() {

And this is really the last comment ;) Why spread this out over three functions? Is it better to have the tagadelic_settings() as a wrapper around one line? Or was that just lazy coding?

Honestly, I don't remember :-)

I rolled it again changing just the strict necessary. It's much cleaner this time.

Yeah, sure

Ups, I left the escaped dollars signs in the comment. Apparently jEdit can't handle variables inside comments :-\ ...

I don't like using @tag instead of %tag tokens.
%tokens are a decfacto standard in Drupal, a standard that I am not about to change, because jEdit cannot handle them properly :)

Well, I made some unnecessary confusion: jEdit has nothing to do with tokens insite t()'s! That's the way Drupal 5 works, see here: http://drupal.org/node/64279#t-placeholders

jEdit was messing up with multiline php comments containing $ signs, so I escaped them with a backslash to be able to work. But I forgot to remove them before rolling the patch, that resulted unclean (#11).

So I rolled it again, see #12

My mistake!

Committed a modified version to HEAD. Please test the new version on HEAD. once I get some positive feedbacks I will branch off the version.

http://cvs.drupal.org/viewcvs/drupal/contributions/modules/tagadelic/tag...